mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime.net>
To: Nir Tzachar <nir.tzachar@gmail.com>
Cc: Michal Marek <mmarek@suse.cz>,
	trapdoor6@gmail.com, Sam Ravnborg <sam@ravnborg.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Justin P. Mattock" <justinmattock@gmail.com>,
	trivial@kernel.org
Subject: Re: Small typo in kernel [current source from git] .config option
Date: Thu, 29 Jul 2010 07:19:14 -0700	[thread overview]
Message-ID: <20100729071914.bf615447.rdunlap@xenotime.net> (raw)
In-Reply-To: <AANLkTi=7ioo3HPVhWYu5OmyoOcaedzyQQ9z=5w2MrTt4@mail.gmail.com>

On Thu, 29 Jul 2010 13:33:49 +0300 Nir Tzachar wrote:

> On Thu, Jul 29, 2010 at 11:05 AM, Michal Marek <mmarek@suse.cz> wrote:
> > On 29.7.2010 08:20, trapDoor wrote:
> >> On Thu, Jul 29, 2010 at 6:04 AM, Nir Tzachar <nir.tzachar@gmail.com> wrote:
> >>> On Wed, Jul 28, 2010 at 9:55 PM, Sam Ravnborg <sam@ravnborg.org> wrote:
> >>>> The capitilazing is the main reason why I have
> >>>> not recommended nconfig to be default.
> >>>>
> >>>> And I doubt the shortcut letters are used that often.
> >>>> One idea could be to drop the shortcut for the individual menus.
> >>>
> >>> I almost never use them and removing them will have the benefit of
> >>> cleaning the code.
> >>
> >> Neither do I. And I don't know anyone who would find them very useful.
> >
> > I actually do. Unlike menuconfig, nconfig will jump to a menu item even
> > if it is not currently visible in the screen. Useful if you know the
> > option name but don't want to scroll down and look for it. But I would
> > accept a patch to remove the shortcut if there is no better way of
> > marking the shortcuts than the capital letters.
> >
> > Michal
> >
> 
> There is a middle ground here: keep the shortcuts, but give no visual
> indication (either capitalization or coloring).

How do you tell libmenue what the shortcut character is?
Is that a different attribute/field/specifier?

If so, how about just adding the shortcut key in parentheses [or square
brackets] after its word or phrase?  E.g.:

	Hardware Error Device [A]


> What do you say? I actually like this, as I dislike the ugly
> capitalization hack.

It's not pretty and it can be confusing, but I would certainly prefer
to have some indicator for the shortcuts.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  reply	other threads:[~2010-07-29 14:19 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-27 14:46 trapDoor
2010-07-27 15:50 ` Justin P. Mattock
2010-07-27 16:35   ` trapDoor
2010-07-27 16:45     ` Justin P. Mattock
2010-07-27 16:55 ` Sam Ravnborg
2010-07-27 17:12   ` trapDoor
2010-07-28 11:02     ` Michal Marek
2010-07-28 12:17       ` trapDoor
2010-07-28 15:41         ` Michal Marek
2010-07-28 18:55           ` Sam Ravnborg
2010-07-29  5:04             ` Nir Tzachar
2010-07-29  6:20               ` trapDoor
2010-07-29  8:05                 ` Michal Marek
2010-07-29 10:33                   ` Nir Tzachar
2010-07-29 14:19                     ` Randy Dunlap [this message]
2010-07-29 19:50                       ` Nir Tzachar
2010-08-01  7:20                         ` [PATCH] nconfig: add search support nir.tzachar
2010-08-01  9:28                           ` Sam Ravnborg
2010-08-01 10:21                             ` Nir Tzachar
2010-08-01 11:49                               ` Sam Ravnborg
2010-08-02 16:32                           ` Randy Dunlap
2010-08-03  4:37                             ` Nir Tzachar
2010-08-02 21:22                           ` rdunlap
2010-08-03  4:41                             ` Nir Tzachar
2010-08-03 12:28                               ` nir.tzachar
2010-08-05 17:04                                 ` Randy Dunlap
2010-08-05 18:13                                   ` Nir Tzachar
2010-08-05 18:19                                     ` Randy Dunlap
2010-08-06 12:41                                       ` Nir Tzachar
2010-08-06 13:54                                     ` Sam Ravnborg
2010-08-06 19:22                                       ` Nir Tzachar
2010-08-06 14:09                                   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100729071914.bf615447.rdunlap@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=justinmattock@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=nir.tzachar@gmail.com \
    --cc=sam@ravnborg.org \
    --cc=trapdoor6@gmail.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®