mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: nir.tzachar@gmail.com
Cc: mmarek@suse.cz, rdunlap@xenotime.net,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	trapdoor6@gmail.com, justinmattock@gmail.com
Subject: Re: [PATCH] nconfig: add search support
Date: Sun, 1 Aug 2010 11:28:59 +0200	[thread overview]
Message-ID: <20100801092859.GA12213@merkur.ravnborg.org> (raw)
In-Reply-To: <1280647233-2578-1-git-send-email-nir.tzachar@gmail.com>

On Sun, Aug 01, 2010 at 10:20:33AM +0300, nir.tzachar@gmail.com wrote:
> From: Nir Tzachar <nir.tzachar@gmail.com>
> 
> Remove the old hotkeys feature, and replace by a regular string search.
> >From nconfig help:
> 
> Pressing '/' triggers search mode. nconfig does regular string match, case
> insensitive, starting at the begining of each menu line.
> Pressing Enter highlights the next match, Backspace removes one character from
> the match string. Pressing either '/' again or ESC exits search mode.
> 
> Rebind the '/' key (which allowed to search for symbols) to F8
> 
> Signed-off-by: Nir Tzachar <nir.tzachar@gmail.com>

Got following warning when I build:
scripts/kconfig/nconf.c: In function ât_mext_matchâscripts/kconfig/nconf.c:512: warning: implicit declaration of function âblankâ

The searching works great! And good to see the capitilazation gone.

But it is ackward that I have to press ESC to leave searcing.

I can navigate up/down, but entering a menu should terminate search.
Also pressing enter (to select a symbol) should terminate search.

I also tried to do first search using "/", then search for a symbol using F8.
Again search was not terminated when I came back.

There is likely much more cases...

	Sam

  reply	other threads:[~2010-08-01  9:29 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-27 14:46 Small typo in kernel [current source from git] .config option trapDoor
2010-07-27 15:50 ` Justin P. Mattock
2010-07-27 16:35   ` trapDoor
2010-07-27 16:45     ` Justin P. Mattock
2010-07-27 16:55 ` Sam Ravnborg
2010-07-27 17:12   ` trapDoor
2010-07-28 11:02     ` Michal Marek
2010-07-28 12:17       ` trapDoor
2010-07-28 15:41         ` Michal Marek
2010-07-28 18:55           ` Sam Ravnborg
2010-07-29  5:04             ` Nir Tzachar
2010-07-29  6:20               ` trapDoor
2010-07-29  8:05                 ` Michal Marek
2010-07-29 10:33                   ` Nir Tzachar
2010-07-29 14:19                     ` Randy Dunlap
2010-07-29 19:50                       ` Nir Tzachar
2010-08-01  7:20                         ` [PATCH] nconfig: add search support nir.tzachar
2010-08-01  9:28                           ` Sam Ravnborg [this message]
2010-08-01 10:21                             ` Nir Tzachar
2010-08-01 11:49                               ` Sam Ravnborg
2010-08-02 16:32                           ` Randy Dunlap
2010-08-03  4:37                             ` Nir Tzachar
2010-08-02 21:22                           ` rdunlap
2010-08-03  4:41                             ` Nir Tzachar
2010-08-03 12:28                               ` nir.tzachar
2010-08-05 17:04                                 ` Randy Dunlap
2010-08-05 18:13                                   ` Nir Tzachar
2010-08-05 18:19                                     ` Randy Dunlap
2010-08-06 12:41                                       ` Nir Tzachar
2010-08-06 13:54                                     ` Sam Ravnborg
2010-08-06 19:22                                       ` Nir Tzachar
2010-08-06 14:09                                   ` Sam Ravnborg
2010-08-08 13:50 nir.tzachar
2010-08-08 15:37 ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100801092859.GA12213@merkur.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=justinmattock@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=nir.tzachar@gmail.com \
    --cc=rdunlap@xenotime.net \
    --cc=trapdoor6@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®