From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Tomasz Buchert <tomasz.buchert@inria.fr>
Cc: linux-kernel@vger.kernel.org,
Daniel Walker <dwalker@codeaurora.org>,
Peter Zijlstra <peterz@infradead.org>,
Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH 2/4] posix-cpu-timers: Introduction of wall clocks
Date: Fri, 30 Jul 2010 13:30:31 +0200 [thread overview]
Message-ID: <20100730133031.76b8f99f@dhcp-lab-109.englab.brq.redhat.com> (raw)
In-Reply-To: <1280483867-6387-3-git-send-email-tomasz.buchert@inria.fr>
On Fri, 30 Jul 2010 11:57:45 +0200
Tomasz Buchert <tomasz.buchert@inria.fr> wrote:
> - read_lock(&tasklist_lock);
> + rcu_read_lock();
> p = find_task_by_vpid(pid);
> if (!p || !(POSIX_CLOCK_PERTHREAD(which_clock) ?
> same_thread_group(p, current) : thread_group_leader(p))) {
> error = -EINVAL;
> }
> - read_unlock(&tasklist_lock);
> + rcu_read_unlock();
IIRC thread_group_leader(p) is wrong here, has_group_leader_pid(p)
should be used. Beside this change alone should be a separate patch,
not part of a "new feature" patch.
Stanislaw
next prev parent reply other threads:[~2010-07-30 11:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 9:57 [PATCH 0/4] Wall time clocks + change in access rules Tomasz Buchert
2010-07-30 9:57 ` [PATCH 1/4] posix-timers: Refactoring of CPUCLOCK* macros Tomasz Buchert
2010-07-30 9:57 ` [PATCH 2/4] posix-cpu-timers: Introduction of wall clocks Tomasz Buchert
2010-07-30 9:57 ` [PATCH 3/4] posix-cpu-timers: Wider access to the thread clocks Tomasz Buchert
2010-07-30 9:57 ` [PATCH 4/4] posix-cpu-timers: posix-cpu-timers.c renamed to posix-task-timers.c Tomasz Buchert
2010-07-30 11:30 ` Stanislaw Gruszka [this message]
2010-07-30 11:23 ` [PATCH 0/4] Wall time clocks + change in access rules Stanislaw Gruszka
2010-07-30 11:51 ` Stanislaw Gruszka
2010-07-30 14:58 ` Rationale for wall clocks Tomasz Buchert
-- strict thread matches above, loose matches on Subject: below --
2010-07-19 21:02 [PATCH 1/4] posix-timers: Refactoring of CPUCLOCK* macros Daniel Walker
2010-07-21 18:03 ` [PATCH 0/4] Wall time clocks + change in access rules Tomasz Buchert
2010-07-21 18:03 ` [PATCH 1/4] posix-timers: Refactoring of CPUCLOCK* macros Tomasz Buchert
2010-07-21 18:03 ` [PATCH 2/4] posix-cpu-timers: Introduction of wall clocks Tomasz Buchert
2010-07-19 11:34 [PATCH 0/4] Wall time clocks + change in access rules Tomasz Buchert
2010-07-19 11:34 ` [PATCH 1/4] posix-timers: Refactoring of CPUCLOCK* macros Tomasz Buchert
2010-07-19 11:34 ` [PATCH 2/4] posix-cpu-timers: Introduction of wall clocks Tomasz Buchert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100730133031.76b8f99f@dhcp-lab-109.englab.brq.redhat.com \
--to=sgruszka@redhat.com \
--cc=dwalker@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tomasz.buchert@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®