Re: [PATCH] x86,setup: add serial_console_port_base in boot_params

[Cyrill Gorcunov <gorcunov@gmail.com>]

On Sat, Jul 31, 2010 at 11:21:35AM -0700, H. Peter Anvin wrote:
> On 07/31/2010 01:34 AM, Cyrill Gorcunov wrote:
> > On Thu, Jul 15, 2010 at 03:27:18PM -0700, Yinghai Lu wrote:
> >>
> >> to save the early_serial_base.
> >>
> >> Also bootloader could fill that field, so setup code could reuse it.
> >>
> >> decompress code could reuse early serial console from setup code.
> >>
> >> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> >>
> > 
> > Hi Yinghai, sorry for delayed response. I like the idea much since it'll allow
> > to log decompressor messages in case if someone would be changing exitsting code
> > or developing new one, though this touches boot protocol so that grub/syslinux
> > and friends will have to update their code as well which of course need some
> > time.
> > 
> 
> No, this is the internal part of the boot protocol, so it's not an issue.
> 

Peter, I didn't mean any issue here, I meant that bootloaders don't know about
this field yet and they will have to update own sources to pass port value
at proper place of boot params. Or I miss something?

> 	-hpa
> 
	-- Cyrill