From: Ingo Molnar <mingo@elte.hu>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Randy Dunlap <rdunlap@xenotime.net>
Subject: [PATCH] NFS: Fix build failure on !CONFIG_NFS_V3 && !CONFIG_NFS_V3
Date: Sun, 1 Aug 2010 08:44:15 +0200 [thread overview]
Message-ID: <20100801064415.GA10523@elte.hu> (raw)
In-Reply-To: <1280519035.12852.32.camel@heimdal.trondhjem.org>
* Trond Myklebust <Trond.Myklebust@netapp.com> wrote:
> Hi Linus,
>
> Please pull from the "bugfixes" branch of the repository at
>
> git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git bugfixes
>
> This will update the following files through the appended changesets.
>
> Cheers,
> Trond
>
> ----
> fs/nfs/file.c | 13 +++++++++++--
> fs/nfs/nfsroot.c | 2 +-
> fs/nfs/write.c | 27 +++++++++++++++++++--------
> include/linux/nfs_fs.h | 1 +
> 4 files changed, 32 insertions(+), 11 deletions(-)
FYI, these commits introduced a build failure on x86:
fs/nfs/file.c:508: error: implicit declaration of function ‘nfs_commit_inode’
The nfs_commit_inode() prototype:
#if defined(CONFIG_NFS_V3) || defined(CONFIG_NFS_V4)
extern int nfs_commit_inode(struct inode *, int);
extern struct nfs_write_data *nfs_commitdata_alloc(void);
extern void nfs_commit_free(struct nfs_write_data *wdata);
#endif
is missing if the kernel is configured for legacy NFS:
CONFIG_NFS_FS=y
# CONFIG_NFS_V3 is not set
# CONFIG_NFS_V4 is not set
The fix below solves the build problem here, but I have not tested whether NFS
still works fine for this config.
Thanks,
Ingo
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
include/linux/nfs_fs.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/include/linux/nfs_fs.h b/include/linux/nfs_fs.h
index f6e2455..bf145c6 100644
--- a/include/linux/nfs_fs.h
+++ b/include/linux/nfs_fs.h
@@ -492,11 +492,9 @@ extern int nfs_writeback_done(struct rpc_task *, struct nfs_write_data *);
extern int nfs_wb_all(struct inode *inode);
extern int nfs_wb_page(struct inode *inode, struct page* page);
extern int nfs_wb_page_cancel(struct inode *inode, struct page* page);
-#if defined(CONFIG_NFS_V3) || defined(CONFIG_NFS_V4)
extern int nfs_commit_inode(struct inode *, int);
extern struct nfs_write_data *nfs_commitdata_alloc(void);
extern void nfs_commit_free(struct nfs_write_data *wdata);
-#endif
static inline int
nfs_have_writebacks(struct inode *inode)
next prev parent reply other threads:[~2010-08-01 6:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 19:43 [GIT PULL] Please pull NFS client bugfixes for 2.6.35-rc6 Trond Myklebust
2010-08-01 6:44 ` Ingo Molnar [this message]
2010-08-01 17:10 ` [PATCH] NFS: Fix build failure on !CONFIG_NFS_V3 && !CONFIG_NFS_V3 Linus Torvalds
2010-08-01 17:35 ` Trond Myklebust
2010-08-01 17:40 ` [PATCH] NFS: Fix a typo in include/linux/nfs_fs.h Trond Myklebust
2010-08-01 19:32 ` Ingo Molnar
2010-08-01 19:45 ` [PATCH] NFS: Fix build failure on !CONFIG_NFS_V3 && !CONFIG_NFS_V3 Christoph Hellwig
2010-08-01 19:56 ` Myklebust, Trond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100801064415.GA10523@elte.hu \
--to=mingo@elte.hu \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome