mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org,
	Randy Dunlap <rdunlap@xenotime.net>
Subject: Re: [PATCH] NFS: Fix a typo in include/linux/nfs_fs.h
Date: Sun, 1 Aug 2010 21:32:05 +0200	[thread overview]
Message-ID: <20100801193205.GA22050@elte.hu> (raw)
In-Reply-To: <1280684440-5763-1-git-send-email-Trond.Myklebust@netapp.com>


* Trond Myklebust <Trond.Myklebust@netapp.com> wrote:

> nfs_commit_inode() needs to be defined irrespectively of whether or not
> we are supporting NFSv3 and NFSv4.
> Allow the compiler to optimise away code in the NFSv2-only case by
> converting it into an inlined stub function.
> 
> Reported-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
> ---
>  fs/nfs/write.c         |    5 -----
>  include/linux/nfs_fs.h |    6 ++++++
>  2 files changed, 6 insertions(+), 5 deletions(-)

I tested this patch too and it solves the problem (and doesnt introduce new 
problems).

Thanks,

	Ingo

  reply	other threads:[~2010-08-01 19:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-30 19:43 [GIT PULL] Please pull NFS client bugfixes for 2.6.35-rc6 Trond Myklebust
2010-08-01  6:44 ` [PATCH] NFS: Fix build failure on !CONFIG_NFS_V3 && !CONFIG_NFS_V3 Ingo Molnar
2010-08-01 17:10   ` Linus Torvalds
2010-08-01 17:35     ` Trond Myklebust
2010-08-01 17:40       ` [PATCH] NFS: Fix a typo in include/linux/nfs_fs.h Trond Myklebust
2010-08-01 19:32         ` Ingo Molnar [this message]
2010-08-01 19:45       ` [PATCH] NFS: Fix build failure on !CONFIG_NFS_V3 && !CONFIG_NFS_V3 Christoph Hellwig
2010-08-01 19:56         ` Myklebust, Trond

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100801193205.GA22050@elte.hu \
    --to=mingo@elte.hu \
    --cc=Trond.Myklebust@netapp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome