[PATCH] writeback: remove wb in get_next_work_item

[PATCH] writeback: remove wb in get_next_work_item

[Minchan Kim]

83ba7b07 cleans up the writeback.
So we don't use wb any more in get_next_work_item.
Let's remove unnecessary argument.

CC: Christoph Hellwig <hch@lst.de>
CC: Jens Axboe <jaxboe@fusionio.com>
Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
---
 fs/fs-writeback.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index a178828..9a55257 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -712,7 +712,7 @@ static long wb_writeback(struct bdi_writeback *wb,
  * Return the next wb_writeback_work struct that hasn't been processed yet.
  */
 static struct wb_writeback_work *
-get_next_work_item(struct backing_dev_info *bdi, struct bdi_writeback *wb)
+get_next_work_item(struct backing_dev_info *bdi)
 {
 	struct wb_writeback_work *work = NULL;
 
@@ -770,7 +770,7 @@ long wb_do_writeback(struct bdi_writeback *wb, int force_wait)
 	struct wb_writeback_work *work;
 	long wrote = 0;
 
-	while ((work = get_next_work_item(bdi, wb)) != NULL) {
+	while ((work = get_next_work_item(bdi)) != NULL) {
 		/*
 		 * Override sync mode, in case we must wait for completion
 		 * because this thread is exiting now.
-- 
1.7.0.5

Re: [PATCH] writeback: remove wb in get_next_work_item

[Christoph Hellwig]

On Sun, Aug 01, 2010 at 11:42:54PM +0900, Minchan Kim wrote:
> 83ba7b07 cleans up the writeback.
> So we don't use wb any more in get_next_work_item.
> Let's remove unnecessary argument.

If we can get it in this merge windows it's fine with me.  If not I have
patches pending that use only the bdi_writeback inside fs/fs-writeback.c
and completely get rid of the backing-dev.

Re: [PATCH] writeback: remove wb in get_next_work_item

[Minchan Kim]

On Mon, Aug 02, 2010 at 02:47:39PM +0200, Christoph Hellwig wrote:
> On Sun, Aug 01, 2010 at 11:42:54PM +0900, Minchan Kim wrote:
> > 83ba7b07 cleans up the writeback.
> > So we don't use wb any more in get_next_work_item.
> > Let's remove unnecessary argument.
> 
> If we can get it in this merge windows it's fine with me.  If not I have
> patches pending that use only the bdi_writeback inside fs/fs-writeback.c
> and completely get rid of the backing-dev.
> 

Yub. I don't care about it.
It's just clean up patch not urgent. 


-- 
Kind regards,
Minchan Kim