From: Wim Van Sebroeck <wim@iguana.be>
To: dann frazier <dannf@hp.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Mingarelli <thomas.mingarelli@hp.com>
Subject: Re: [PATCH 09/15] Despecificate driver from iLO2
Date: Wed, 4 Aug 2010 22:13:41 +0200 [thread overview]
Message-ID: <20100804201341.GC30740@infomag.iguana.be> (raw)
In-Reply-To: <1280274663-9160-10-git-send-email-dannf@hp.com>
Hi Dan,
> This driver supports both iLO2 and iLO3, but our user-visible strings
> currently only reference iLO2. Let's just call it "iLO" to avoid having
> to update strings for each iLO generation. This driver doesn't support
> iLO ASICs prior to iLO2, but that is sufficiently explained in Kconfig.
Just a thought: Wouldn't it be more consistent if it's called iLO2+ everywhere?
> - tristate "HP Proliant iLO 2 Hardware Watchdog Timer"
> + tristate "HP Proliant iLO Hardware Watchdog Timer"
would be: tristate "HP Proliant iLO2+ Hardware Watchdog Timer"
> - .identity = "HP iLO2 HW Watchdog Timer",
> + .identity = "HP iLO HW Watchdog Timer",
and: .identity = "HP iLO2+ HW Watchdog Timer",
> - * First let's find out if we are on an iLO2 server. We will
> + * First let's find out if we are on an iLO2+ server. We will
> - dev_warn(&dev->dev,
> - "This server does not have an iLO2 ASIC.\n");
> + dev_warn(&dev->dev, "This server does not have an iLO ASIC"
> + " version 2 or greater.\n");
dev_warn(&dev->dev,
"This server does not have an iLO2+ ASIC.\n");
> - "Unable to detect the iLO2 server memory.\n");
> + "Unable to detect the iLO server memory.\n");
"Unable to detect the iLO2+ server memory.\n");
For the rest I'm still reviewing the code.
Kind regards,
Wim.
next prev parent reply other threads:[~2010-08-04 20:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 23:50 [PATCH 00/15] hpwdt: make NMI code a config option (+ other cleanup) dann frazier
2010-07-27 23:50 ` [PATCH 01/15] hpwdt_pretimeout reorganization dann frazier
2010-07-27 23:50 ` [PATCH 02/15] remove unnecessary includes dann frazier
2010-07-27 23:50 ` [PATCH 03/15] include spinlock.h dann frazier
2010-07-27 23:50 ` [PATCH 04/15] add include for linux/bitops.h dann frazier
2010-07-27 23:50 ` [PATCH 05/15] Group together includes specific to NMI sourcing dann frazier
2010-07-27 23:50 ` [PATCH 06/15] Group options that affect watchdog behavior together dann frazier
2010-07-27 23:50 ` [PATCH 07/15] Group defines only used by NMI sourcing together dann frazier
2010-07-27 23:50 ` [PATCH 08/15] Group declarations specific to " dann frazier
2010-07-27 23:50 ` [PATCH 09/15] Despecificate driver from iLO2 dann frazier
2010-08-04 20:13 ` Wim Van Sebroeck [this message]
2010-08-04 20:18 ` Mingarelli, Thomas
2010-08-05 5:10 ` dann frazier
2010-07-27 23:50 ` [PATCH 10/15] Fix a typo dann frazier
2010-07-27 23:50 ` [PATCH 11/15] Make x86 assembly ifdef guard more strict dann frazier
2010-07-27 23:51 ` [PATCH 12/15] Construct status message w/ kasprintf and emit it with dev_info dann frazier
2010-07-28 18:38 ` dann frazier
2010-07-27 23:51 ` [PATCH 13/15] Use "decoding" instead of "sourcing" dann frazier
2010-07-27 23:51 ` [PATCH 14/15] Make NMI decoding a compile-time option dann frazier
2010-07-27 23:51 ` [PATCH 15/15] Bump version to 1.2.0 dann frazier
2010-07-28 13:10 ` [PATCH 00/15] hpwdt: make NMI code a config option (+ other cleanup) Mingarelli, Thomas
2010-08-05 21:41 ` Wim Van Sebroeck
2010-08-06 21:26 ` Wim Van Sebroeck
2010-08-06 21:29 ` dann frazier
2010-08-11 12:49 ` Wim Van Sebroeck
2010-08-13 7:29 ` dann frazier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100804201341.GC30740@infomag.iguana.be \
--to=wim@iguana.be \
--cc=dannf@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.mingarelli@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome