[GIT PULL 0/3] perf/core fixes and improvements

[GIT PULL 0/3] perf/core fixes and improvements

[Arnaldo Carvalho de Melo]

Hi Ingo,

        Please pull from:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core

Regards,

- Arnaldo

Dave Martin (1):
  perf events: Fix mmap offset determination

Srikar Dronamraju (2):
  perf: expose event__process function
  tracing/kprobes: unregister_trace_probe needs to be called under mutex

 kernel/trace/trace_kprobe.c |    3 +++
 tools/perf/builtin-top.c    |   20 --------------------
 tools/perf/util/event.c     |   28 +++++++++++++++++++++-------
 tools/perf/util/event.h     |    1 +
 4 files changed, 25 insertions(+), 27 deletions(-)

[PATCH 1/3] perf events: Fix mmap offset determination

[Arnaldo Carvalho de Melo]

From: Dave Martin <dave.martin@linaro.org>

Fix buggy-looking code which unnecessarily adjusts the file offset
fields read from /proc/*/maps.

This may have gone unnoticed since the offset is usually 0 (and the
logic in util/symbol.c may work incorrectly for other offset values).

Commiter note:

This fixes a bug introduced in 4af8b35, there is no need to shift pgoff
twice, the show_map_vma routine in fs/proc/task_mmu.c already converts
it from the number of pages to the size in bytes, and that is what
appears in /proc/PID/map.

Cc: Anton Blanchard <anton@samba.org>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Will Deacon <Will.Deacon@arm.com>
LKML-Reference: <1280836116-6654-2-git-send-email-dave.martin@linaro.org>
Signed-off-by: Dave Martin <dave.martin@linaro.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/event.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 6b0db55..db8a1d4 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -151,7 +151,6 @@ static int event__synthesize_mmap_events(pid_t pid, pid_t tgid,
 			continue;
 		pbf += n + 3;
 		if (*pbf == 'x') { /* vm_exec */
-			u64 vm_pgoff;
 			char *execname = strchr(bf, '/');
 
 			/* Catch VDSO */
@@ -162,12 +161,7 @@ static int event__synthesize_mmap_events(pid_t pid, pid_t tgid,
 				continue;
 
 			pbf += 3;
-			n = hex2u64(pbf, &vm_pgoff);
-			/* pgoff is in bytes, not pages */
-			if (n >= 0)
-				ev.mmap.pgoff = vm_pgoff << getpagesize();
-			else
-				ev.mmap.pgoff = 0;
+			n = hex2u64(pbf, &ev.mmap.pgoff);
 
 			size = strlen(execname);
 			execname[size - 1] = '\0'; /* Remove \n */
-- 
1.6.2.5

[PATCH 2/3] perf: expose event__process function

[Arnaldo Carvalho de Melo]

From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

The event__process function is useful in processing /proc/<pid>/maps.  All of
the functions that are called from event__process are defined in util/event.c.
Though its defined in builtin-top.c, it could be reused for perf probe for
uprobes. Hence moving it to util/event.c and exporting the function.

LKML-Reference: <20100802123851.GD22812@linux.vnet.ibm.com>
Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-top.c |   20 --------------------
 tools/perf/util/event.c  |   20 ++++++++++++++++++++
 tools/perf/util/event.h  |    1 +
 3 files changed, 21 insertions(+), 20 deletions(-)

diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 1e8e92e..b513e40 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -1082,26 +1082,6 @@ static void event__process_sample(const event_t *self,
 	}
 }
 
-static int event__process(event_t *event, struct perf_session *session)
-{
-	switch (event->header.type) {
-	case PERF_RECORD_COMM:
-		event__process_comm(event, session);
-		break;
-	case PERF_RECORD_MMAP:
-		event__process_mmap(event, session);
-		break;
-	case PERF_RECORD_FORK:
-	case PERF_RECORD_EXIT:
-		event__process_task(event, session);
-		break;
-	default:
-		break;
-	}
-
-	return 0;
-}
-
 struct mmap_data {
 	int			counter;
 	void			*base;
diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index db8a1d4..dab9e75 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -548,6 +548,26 @@ int event__process_task(event_t *self, struct perf_session *session)
 	return 0;
 }
 
+int event__process(event_t *event, struct perf_session *session)
+{
+	switch (event->header.type) {
+	case PERF_RECORD_COMM:
+		event__process_comm(event, session);
+		break;
+	case PERF_RECORD_MMAP:
+		event__process_mmap(event, session);
+		break;
+	case PERF_RECORD_FORK:
+	case PERF_RECORD_EXIT:
+		event__process_task(event, session);
+		break;
+	default:
+		break;
+	}
+
+	return 0;
+}
+
 void thread__find_addr_map(struct thread *self,
 			   struct perf_session *session, u8 cpumode,
 			   enum map_type type, pid_t pid, u64 addr,
diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h
index 887ee63..8e790da 100644
--- a/tools/perf/util/event.h
+++ b/tools/perf/util/event.h
@@ -154,6 +154,7 @@ int event__process_comm(event_t *self, struct perf_session *session);
 int event__process_lost(event_t *self, struct perf_session *session);
 int event__process_mmap(event_t *self, struct perf_session *session);
 int event__process_task(event_t *self, struct perf_session *session);
+int event__process(event_t *event, struct perf_session *session);
 
 struct addr_location;
 int event__preprocess_sample(const event_t *self, struct perf_session *session,
-- 
1.6.2.5

[PATCH 3/3] tracing/kprobes: unregister_trace_probe needs to be called under mutex

[Arnaldo Carvalho de Melo]

From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

Comment in unregister_trace_probe() says probe_lock will be held when it
gets called. However there is a case where it might called without the
probe_lock being held. Also since we are traversing the probe_list and
deleting an element from the probe_list, probe_lock should be held.

This was first pointed in uprobes traceevent review by Frederic
Weisbecker here.  (http://lkml.org/lkml/2010/5/12/106)

Cc: Ingo Molnar <mingo@elte.hu>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
LKML-Reference: <20100630084548.GA10325@linux.vnet.ibm.com>
Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 kernel/trace/trace_kprobe.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
index 1b79d1c..8b27c98 100644
--- a/kernel/trace/trace_kprobe.c
+++ b/kernel/trace/trace_kprobe.c
@@ -925,14 +925,17 @@ static int create_trace_probe(int argc, char **argv)
 			pr_info("Delete command needs an event name.\n");
 			return -EINVAL;
 		}
+		mutex_lock(&probe_lock);
 		tp = find_probe_event(event, group);
 		if (!tp) {
+			mutex_unlock(&probe_lock);
 			pr_info("Event %s/%s doesn't exist.\n", group, event);
 			return -ENOENT;
 		}
 		/* delete an event */
 		unregister_trace_probe(tp);
 		free_trace_probe(tp);
+		mutex_unlock(&probe_lock);
 		return 0;
 	}
 
-- 
1.6.2.5

Re: [GIT PULL 0/3] perf/core fixes and improvements

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> 
> Hi Ingo,
> 
>         Please pull from:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core
> 
> Regards,
> 
> - Arnaldo
> 
> Dave Martin (1):
>   perf events: Fix mmap offset determination
> 
> Srikar Dronamraju (2):
>   perf: expose event__process function
>   tracing/kprobes: unregister_trace_probe needs to be called under mutex
> 
>  kernel/trace/trace_kprobe.c |    3 +++
>  tools/perf/builtin-top.c    |   20 --------------------
>  tools/perf/util/event.c     |   28 +++++++++++++++++++++-------
>  tools/perf/util/event.h     |    1 +
>  4 files changed, 25 insertions(+), 27 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

Re: [GIT PULL 0/3] perf/core fixes and improvements

[Arnaldo Carvalho de Melo]

Em Mon, Mar 19, 2012 at 08:47:25PM +0100, Ingo Molnar escreveu:
> Pulled, thanks Arnaldo!
> 
> I noticed that there's no help text for GTK support - how will a 
> user find that 'perf report --gtk' will do something nice?
> 
> Another detail is that if GTK support is not compiled in:
> 
> Makefile:515: GTK2 not found, disables GTK2 support. Please install gtk2-devel or libgtk2.0-dev
> 
> then the --gtk output is not very informative:
> 
>   earth5:~/tip/tools/perf> perf report --gtk
>   earth5:~/tip/tools/perf> 
> 
> :-)
> 
> A third detail, I do have gtk2-devel installed:
> 
>  Package gtk2-devel-2.24.10-1.fc17.x86_64 already installed and latest version

Yeah, as you said, the ball is rolling! ;-)

> yet I got the above message.
> 
> It is not easy to figure out *why* a feature test failed, 
> unfortunately. It would be nice if V=1 or something like that 
> would output the failure.

Yeah, I also was frustrated by V=1 not affecting the feature tests, and
did what you did, just didn't got around to fix it properly.
 
> I applied the hack below and ran the gtk testcase, which gave:
> 
> earth5:~/tip/tools/perf> . ./test.4273.sh
> In file included from /usr/lib64/glib-2.0/include/glibconfig.h:9:0,
>                  from /usr/include/glib-2.0/glib/gtypes.h:34,
>                  from /usr/include/glib-2.0/glib/galloca.h:34,
>                  from /usr/include/glib-2.0/glib.h:32,
>                  from /usr/include/glib-2.0/gobject/gbinding.h:30,
>                  from /usr/include/glib-2.0/glib-object.h:25,
>                  from /usr/include/glib-2.0/gio/gioenums.h:30,
>                  from /usr/include/glib-2.0/gio/giotypes.h:30,
>                  from /usr/include/glib-2.0/gio/gio.h:28,
>                  from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
>                  from /usr/include/gtk-2.0/gdk/gdk.h:32,
>                  from /usr/include/gtk-2.0/gtk/gtk.h:32,
>                  from test.4273.c:2:
> /usr/include/glib-2.0/glib/gmacros.h:346:7: error: "_MSC_VER" is not defined [-Werror=undef]
> cc1: all warnings being treated as errors
> 
> Which allowed me to fix the feature test and the gtk.h include 
> file wrapper via the second patch below.
> 
> And then I was greeted by the GTK report window on 'perf report 
> --gtk' ;-)
> 
> Thanks,
> 
> 	Ingo
> 
> diff --git a/tools/perf/config/utilities.mak b/tools/perf/config/utilities.mak
> index 8046182..68cf795 100644
> --- a/tools/perf/config/utilities.mak
> +++ b/tools/perf/config/utilities.mak
> @@ -183,6 +183,8 @@ _gea_err  = $(if $(1),$(error Please set '$(1)' appropriately))
>  # Usage: option = $(call try-cc, source-to-build, cc-options)
>  try-cc = $(shell sh -c						  \
>  	'TMP="$(OUTPUT)$(TMPOUT).$$$$";				  \
> +	 echo "$(1)" > test.$$$$.c;					  \
> +	 echo $(CC) -x c test.$$$$.c $(2) -o "$$TMP" > test.$$$$.sh;		  \
>  	 echo "$(1)" |						  \
>  	 $(CC) -x c - $(2) -o "$$TMP" > /dev/null 2>&1 && echo y; \
>  	 rm -f "$$TMP"')
> 
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> 
> diff --git a/tools/perf/config/feature-tests.mak b/tools/perf/config/feature-tests.mak
> index d9084e0..ae8b471 100644
> --- a/tools/perf/config/feature-tests.mak
> +++ b/tools/perf/config/feature-tests.mak
> @@ -68,7 +68,9 @@ endif
>  ifndef NO_GTK2
>  define SOURCE_GTK2
>  #pragma GCC diagnostic ignored \"-Wstrict-prototypes\"
> +#pragma GCC diagnostic ignored \"-Wundef\"
>  #include <gtk/gtk.h>
> +#pragma GCC diagnostic error \"-Wundef\"
>  #pragma GCC diagnostic error \"-Wstrict-prototypes\"
>  
>  int main(int argc, char *argv[])
> diff --git a/tools/perf/util/gtk/gtk.h b/tools/perf/util/gtk/gtk.h
> index 75177ee..c7a941f 100644
> --- a/tools/perf/util/gtk/gtk.h
> +++ b/tools/perf/util/gtk/gtk.h
> @@ -2,7 +2,9 @@
>  #define _PERF_GTK_H_ 1
>  
>  #pragma GCC diagnostic ignored "-Wstrict-prototypes"
> +#pragma GCC diagnostic ignored "-Wundef"
>  #include <gtk/gtk.h>
> +#pragma GCC diagnostic error "-Wundef"
>  #pragma GCC diagnostic error "-Wstrict-prototypes"
>  
>  #endif /* _PERF_GTK_H_ */

Re: [GIT PULL 0/3] perf/core fixes and improvements

[Ingo Molnar]

* Ingo Molnar <mingo@kernel.org> wrote:

> I noticed that there's no help text for GTK support - how will a 
> user find that 'perf report --gtk' will do something nice?

Ignore this one - I forgot to do 'make install-doc'.

Thanks,

	Ingo

Re: [GIT PULL 0/3] perf/core fixes and improvements

[Ingo Molnar]

* Ingo Molnar <mingo@kernel.org> wrote:

> diff --git a/tools/perf/config/utilities.mak b/tools/perf/config/utilities.mak
> index 8046182..68cf795 100644
> --- a/tools/perf/config/utilities.mak
> +++ b/tools/perf/config/utilities.mak
> @@ -183,6 +183,8 @@ _gea_err  = $(if $(1),$(error Please set '$(1)' appropriately))
>  # Usage: option = $(call try-cc, source-to-build, cc-options)
>  try-cc = $(shell sh -c						  \
>  	'TMP="$(OUTPUT)$(TMPOUT).$$$$";				  \
> +	 echo "$(1)" > test.$$$$.c;					  \
> +	 echo $(CC) -x c test.$$$$.c $(2) -o "$$TMP" > test.$$$$.sh;		  \
>  	 echo "$(1)" |						  \
>  	 $(CC) -x c - $(2) -o "$$TMP" > /dev/null 2>&1 && echo y; \
>  	 rm -f "$$TMP"')

So, instead of this hack we'd like to output the build failure 
that gcc gives, when 'make V=1' is specified or so.

Thanks,

	Ingo

Re: [GIT PULL 0/3] perf/core fixes and improvements

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling, now there are two pull request worth of
> changesets in my perf/core branch,
> 
> - Arnaldo
> 
> The following changes since commit 6db6127c4dad634ab98709b81e2f2770890b0d53:
> 
>   perf report: Treat an argument as a symbol filter (2012-03-16 16:44:36 -0300)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
> 
> for you to fetch changes up to c31a94570552dcaa517c4f7a043ffd28835016be:
> 
>   perf report: Add a simple GTK2-based 'perf report' browser (2012-03-19 15:13:29 -0300)
> 
> ----------------------------------------------------------------
> Fixes for the last batch from Namhyung and the initial GTK report browser
> from Pekka.
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Namhyung Kim (2):
>       perf ui browser: Clean lines inside of the input window
>       perf report: Document --symbol-filter option
> 
> Pekka Enberg (1):
>       perf report: Add a simple GTK2-based 'perf report' browser
> 
>  tools/perf/Documentation/perf-report.txt |    5 +
>  tools/perf/Makefile                      |   14 +++
>  tools/perf/builtin-report.c              |   19 ++-
>  tools/perf/config/feature-tests.mak      |   15 +++
>  tools/perf/util/cache.h                  |   12 ++
>  tools/perf/util/gtk/browser.c            |  189 ++++++++++++++++++++++++++++++
>  tools/perf/util/gtk/gtk.h                |    8 ++
>  tools/perf/util/hist.h                   |   17 +++
>  tools/perf/util/ui/util.c                |   10 +-
>  9 files changed, 282 insertions(+), 7 deletions(-)
>  create mode 100644 tools/perf/util/gtk/browser.c
>  create mode 100644 tools/perf/util/gtk/gtk.h

Pulled, thanks Arnaldo!

I noticed that there's no help text for GTK support - how will a 
user find that 'perf report --gtk' will do something nice?

Another detail is that if GTK support is not compiled in:

Makefile:515: GTK2 not found, disables GTK2 support. Please install gtk2-devel or libgtk2.0-dev

then the --gtk output is not very informative:

  earth5:~/tip/tools/perf> perf report --gtk
  earth5:~/tip/tools/perf> 

:-)

A third detail, I do have gtk2-devel installed:

 Package gtk2-devel-2.24.10-1.fc17.x86_64 already installed and latest version

yet I got the above message.

It is not easy to figure out *why* a feature test failed, 
unfortunately. It would be nice if V=1 or something like that 
would output the failure.

I applied the hack below and ran the gtk testcase, which gave:

earth5:~/tip/tools/perf> . ./test.4273.sh
In file included from /usr/lib64/glib-2.0/include/glibconfig.h:9:0,
                 from /usr/include/glib-2.0/glib/gtypes.h:34,
                 from /usr/include/glib-2.0/glib/galloca.h:34,
                 from /usr/include/glib-2.0/glib.h:32,
                 from /usr/include/glib-2.0/gobject/gbinding.h:30,
                 from /usr/include/glib-2.0/glib-object.h:25,
                 from /usr/include/glib-2.0/gio/gioenums.h:30,
                 from /usr/include/glib-2.0/gio/giotypes.h:30,
                 from /usr/include/glib-2.0/gio/gio.h:28,
                 from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
                 from /usr/include/gtk-2.0/gdk/gdk.h:32,
                 from /usr/include/gtk-2.0/gtk/gtk.h:32,
                 from test.4273.c:2:
/usr/include/glib-2.0/glib/gmacros.h:346:7: error: "_MSC_VER" is not defined [-Werror=undef]
cc1: all warnings being treated as errors

Which allowed me to fix the feature test and the gtk.h include 
file wrapper via the second patch below.

And then I was greeted by the GTK report window on 'perf report 
--gtk' ;-)

Thanks,

	Ingo

diff --git a/tools/perf/config/utilities.mak b/tools/perf/config/utilities.mak
index 8046182..68cf795 100644
--- a/tools/perf/config/utilities.mak
+++ b/tools/perf/config/utilities.mak
@@ -183,6 +183,8 @@ _gea_err  = $(if $(1),$(error Please set '$(1)' appropriately))
 # Usage: option = $(call try-cc, source-to-build, cc-options)
 try-cc = $(shell sh -c						  \
 	'TMP="$(OUTPUT)$(TMPOUT).$$$$";				  \
+	 echo "$(1)" > test.$$$$.c;					  \
+	 echo $(CC) -x c test.$$$$.c $(2) -o "$$TMP" > test.$$$$.sh;		  \
 	 echo "$(1)" |						  \
 	 $(CC) -x c - $(2) -o "$$TMP" > /dev/null 2>&1 && echo y; \
 	 rm -f "$$TMP"')

Signed-off-by: Ingo Molnar <mingo@elte.hu>

diff --git a/tools/perf/config/feature-tests.mak b/tools/perf/config/feature-tests.mak
index d9084e0..ae8b471 100644
--- a/tools/perf/config/feature-tests.mak
+++ b/tools/perf/config/feature-tests.mak
@@ -68,7 +68,9 @@ endif
 ifndef NO_GTK2
 define SOURCE_GTK2
 #pragma GCC diagnostic ignored \"-Wstrict-prototypes\"
+#pragma GCC diagnostic ignored \"-Wundef\"
 #include <gtk/gtk.h>
+#pragma GCC diagnostic error \"-Wundef\"
 #pragma GCC diagnostic error \"-Wstrict-prototypes\"
 
 int main(int argc, char *argv[])
diff --git a/tools/perf/util/gtk/gtk.h b/tools/perf/util/gtk/gtk.h
index 75177ee..c7a941f 100644
--- a/tools/perf/util/gtk/gtk.h
+++ b/tools/perf/util/gtk/gtk.h
@@ -2,7 +2,9 @@
 #define _PERF_GTK_H_ 1
 
 #pragma GCC diagnostic ignored "-Wstrict-prototypes"
+#pragma GCC diagnostic ignored "-Wundef"
 #include <gtk/gtk.h>
+#pragma GCC diagnostic error "-Wundef"
 #pragma GCC diagnostic error "-Wstrict-prototypes"
 
 #endif /* _PERF_GTK_H_ */

[GIT PULL 0/3] perf/core fixes and improvements

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling, now there are two pull request worth of
changesets in my perf/core branch,

- Arnaldo

The following changes since commit 6db6127c4dad634ab98709b81e2f2770890b0d53:

  perf report: Treat an argument as a symbol filter (2012-03-16 16:44:36 -0300)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo

for you to fetch changes up to c31a94570552dcaa517c4f7a043ffd28835016be:

  perf report: Add a simple GTK2-based 'perf report' browser (2012-03-19 15:13:29 -0300)

----------------------------------------------------------------
Fixes for the last batch from Namhyung and the initial GTK report browser
from Pekka.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Namhyung Kim (2):
      perf ui browser: Clean lines inside of the input window
      perf report: Document --symbol-filter option

Pekka Enberg (1):
      perf report: Add a simple GTK2-based 'perf report' browser

 tools/perf/Documentation/perf-report.txt |    5 +
 tools/perf/Makefile                      |   14 +++
 tools/perf/builtin-report.c              |   19 ++-
 tools/perf/config/feature-tests.mak      |   15 +++
 tools/perf/util/cache.h                  |   12 ++
 tools/perf/util/gtk/browser.c            |  189 ++++++++++++++++++++++++++++++
 tools/perf/util/gtk/gtk.h                |    8 ++
 tools/perf/util/hist.h                   |   17 +++
 tools/perf/util/ui/util.c                |   10 +-
 9 files changed, 282 insertions(+), 7 deletions(-)
 create mode 100644 tools/perf/util/gtk/browser.c
 create mode 100644 tools/perf/util/gtk/gtk.h

Re: [GIT PULL 0/3] perf/core fixes and improvements

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> The following changes since commit 09bda4432a8a4d4db2b2b94697abc8d732a9ff73:
> 
>   Merge branch 'tip/perf/core' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace into perf/core (2012-02-17 12:55:07 +0100)
> 
> are available in the git repository at:
> 
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf-core-for-mingo
> 
> for you to fetch changes up to 6b1bee9035d430c4b4f586df6df4b3f840e89b5b:
> 
>   perf tools: fix broken perf record -a mode (2012-02-21 15:05:43 -0200)
> 
> ----------------------------------------------------------------
> Important fix from Stephane for system wide monitoring, problem
> introduced recently in the pid list patches.
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Danny Kukawka (1):
>       perf tools: Remove duplicated string.h includes
> 
> Stefan Hajnoczi (1):
>       perf tools: Allow expressions in __print_symbolic() fields
> 
> Stephane Eranian (1):
>       perf tools: fix broken perf record -a mode
> 
>  tools/perf/util/probe-event.c       |    1 -
>  tools/perf/util/thread_map.c        |    2 +-
>  tools/perf/util/trace-event-parse.c |   12 ++++++++++++
>  3 files changed, 13 insertions(+), 2 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 0/3] perf/core fixes and improvements

[Arnaldo Carvalho de Melo]

The following changes since commit 09bda4432a8a4d4db2b2b94697abc8d732a9ff73:

  Merge branch 'tip/perf/core' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace into perf/core (2012-02-17 12:55:07 +0100)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf-core-for-mingo

for you to fetch changes up to 6b1bee9035d430c4b4f586df6df4b3f840e89b5b:

  perf tools: fix broken perf record -a mode (2012-02-21 15:05:43 -0200)

----------------------------------------------------------------
Important fix from Stephane for system wide monitoring, problem
introduced recently in the pid list patches.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Danny Kukawka (1):
      perf tools: Remove duplicated string.h includes

Stefan Hajnoczi (1):
      perf tools: Allow expressions in __print_symbolic() fields

Stephane Eranian (1):
      perf tools: fix broken perf record -a mode

 tools/perf/util/probe-event.c       |    1 -
 tools/perf/util/thread_map.c        |    2 +-
 tools/perf/util/trace-event-parse.c |   12 ++++++++++++
 3 files changed, 13 insertions(+), 2 deletions(-)

Re: [GIT PULL 0/3] perf/core fixes and improvements

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Hi Ingo,
> 
>         Please consider pulling from:
> 
> git://github.com/acmel/linux.git perf/core
> 
> Regards,
> 
> - Arnaldo
> 
> Andrew Vagin (1):
>   perf tools: Add ability to synthesize event according to a sample
> 
> Robert Richter (2):
>   perf script: Fix mem leaks and NULL pointer checks around strdup()s
>   perf script: Implement option for system-wide profiling
> 
>  tools/perf/builtin-script.c |   63 +++++++++++++++++++++-------------
>  tools/perf/util/event.h     |    3 ++
>  tools/perf/util/evsel.c     |   79 +++++++++++++++++++++++++++++++++++++++++++
>  tools/perf/util/session.h   |    8 ++++
>  4 files changed, 129 insertions(+), 24 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 0/3] perf/core fixes and improvements

[Arnaldo Carvalho de Melo]

Hi Ingo,

        Please consider pulling from:

git://github.com/acmel/linux.git perf/core

Regards,

- Arnaldo

Andrew Vagin (1):
  perf tools: Add ability to synthesize event according to a sample

Robert Richter (2):
  perf script: Fix mem leaks and NULL pointer checks around strdup()s
  perf script: Implement option for system-wide profiling

 tools/perf/builtin-script.c |   63 +++++++++++++++++++++-------------
 tools/perf/util/event.h     |    3 ++
 tools/perf/util/evsel.c     |   79 +++++++++++++++++++++++++++++++++++++++++++
 tools/perf/util/session.h   |    8 ++++
 4 files changed, 129 insertions(+), 24 deletions(-)

-- 
1.7.8.rc0.35.gee6df

Re: [GIT PULL 0/3] perf/core fixes and improvements

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Hi Ingo,
> 
>         Please consider pulling from:
> 
> git://github.com/acmel/linux.git perf/core
> 
> Regards,
> 
> - Arnaldo
> 
> Arnaldo Carvalho de Melo (2):
>   perf hists browser: Warn about lost events
>   perf report: Add progress bar when processing time ordered events
> 
> Masami Hiramatsu (1):
>   perf tools: Fix a typo of command name as trace-cmd
> 
>  tools/perf/builtin-top.c            |   41 +++++++++++++++++++++--------
>  tools/perf/util/hist.h              |    1 +
>  tools/perf/util/session.c           |   38 ++++++++++++++++++++++----
>  tools/perf/util/session.h           |    1 +
>  tools/perf/util/top.h               |    1 -
>  tools/perf/util/trace-event-info.c  |    2 +-
>  tools/perf/util/ui/browser.c        |   21 ++++++++++++---
>  tools/perf/util/ui/browser.h        |    3 +-
>  tools/perf/util/ui/browsers/hists.c |   49 ++++++++++++++++++++++++++++++----
>  9 files changed, 127 insertions(+), 30 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 0/3] perf/core fixes and improvements

[Arnaldo Carvalho de Melo]

Hi Ingo,

        Please consider pulling from:

git://github.com/acmel/linux.git perf/core

Regards,

- Arnaldo

Arnaldo Carvalho de Melo (2):
  perf hists browser: Warn about lost events
  perf report: Add progress bar when processing time ordered events

Masami Hiramatsu (1):
  perf tools: Fix a typo of command name as trace-cmd

 tools/perf/builtin-top.c            |   41 +++++++++++++++++++++--------
 tools/perf/util/hist.h              |    1 +
 tools/perf/util/session.c           |   38 ++++++++++++++++++++++----
 tools/perf/util/session.h           |    1 +
 tools/perf/util/top.h               |    1 -
 tools/perf/util/trace-event-info.c  |    2 +-
 tools/perf/util/ui/browser.c        |   21 ++++++++++++---
 tools/perf/util/ui/browser.h        |    3 +-
 tools/perf/util/ui/browsers/hists.c |   49 ++++++++++++++++++++++++++++++----
 9 files changed, 127 insertions(+), 30 deletions(-)

Re: [GIT PULL 0/3] perf/core fixes and improvements

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Hi Ingo,
> 
>         Please consider pulling from:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core
> 
> Regards,
> 
> - Arnaldo
> 
> Arnaldo Carvalho de Melo (3):
>   perf session: Pass evsel in event_ops->sample()
>   perf build-id: Add quirk to deal with perf.data file format breakage
>   perf symbols: Look at .dynsym again if .symtab not found
> 
>  tools/perf/builtin-annotate.c                      |   18 ++-----
>  tools/perf/builtin-diff.c                          |    1 +
>  tools/perf/builtin-inject.c                        |   11 ++++-
>  tools/perf/builtin-kmem.c                          |    1 +
>  tools/perf/builtin-lock.c                          |    4 +-
>  tools/perf/builtin-report.c                        |   19 ++-----
>  tools/perf/builtin-sched.c                         |    1 +
>  tools/perf/builtin-script.c                        |   15 ++----
>  tools/perf/builtin-timechart.c                     |   11 ++++
>  tools/perf/util/build-id.c                         |    1 +
>  tools/perf/util/header.c                           |   57 +++++++++++++++++++-
>  tools/perf/util/hist.h                             |    1 +
>  .../perf/util/scripting-engines/trace-event-perl.c |    1 +
>  .../util/scripting-engines/trace-event-python.c    |    1 +
>  tools/perf/util/session.c                          |   25 ++++++++-
>  tools/perf/util/session.h                          |    7 ++-
>  tools/perf/util/symbol.c                           |   25 +++++----
>  tools/perf/util/trace-event-scripting.c            |    1 +
>  tools/perf/util/trace-event.h                      |    1 +
>  19 files changed, 142 insertions(+), 59 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 0/3] perf/core fixes and improvements

[Arnaldo Carvalho de Melo]

Hi Ingo,

        Please consider pulling from:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core

Regards,

- Arnaldo

Arnaldo Carvalho de Melo (3):
  perf session: Pass evsel in event_ops->sample()
  perf build-id: Add quirk to deal with perf.data file format breakage
  perf symbols: Look at .dynsym again if .symtab not found

 tools/perf/builtin-annotate.c                      |   18 ++-----
 tools/perf/builtin-diff.c                          |    1 +
 tools/perf/builtin-inject.c                        |   11 ++++-
 tools/perf/builtin-kmem.c                          |    1 +
 tools/perf/builtin-lock.c                          |    4 +-
 tools/perf/builtin-report.c                        |   19 ++-----
 tools/perf/builtin-sched.c                         |    1 +
 tools/perf/builtin-script.c                        |   15 ++----
 tools/perf/builtin-timechart.c                     |   11 ++++
 tools/perf/util/build-id.c                         |    1 +
 tools/perf/util/header.c                           |   57 +++++++++++++++++++-
 tools/perf/util/hist.h                             |    1 +
 .../perf/util/scripting-engines/trace-event-perl.c |    1 +
 .../util/scripting-engines/trace-event-python.c    |    1 +
 tools/perf/util/session.c                          |   25 ++++++++-
 tools/perf/util/session.h                          |    7 ++-
 tools/perf/util/symbol.c                           |   25 +++++----
 tools/perf/util/trace-event-scripting.c            |    1 +
 tools/perf/util/trace-event.h                      |    1 +
 19 files changed, 142 insertions(+), 59 deletions(-)

Re: [GIT PULL 0/3] perf/core fixes and improvements

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Hi Ingo,
> 
>         Please consider pulling from:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core
> 
> Regards,
> 
> - Arnaldo
> 
> Arnaldo Carvalho de Melo (2):
>   perf symbols: Improve kallsyms symbol end addr calculation
>   perf test: Look forward for symbol aliases
> 
> Franck Bui-Huu (1):
>   perf probe: Fix wrong warning in __show_one_line() if read(1) errors
>     happen
> 
>  tools/perf/builtin-test.c     |   23 ++++++++++++++---
>  tools/perf/util/event.c       |    3 +-
>  tools/perf/util/probe-event.c |    2 +-
>  tools/perf/util/symbol.c      |   56 ++++++++++++++++++++++++++++++----------
>  tools/perf/util/symbol.h      |    2 +-
>  5 files changed, 65 insertions(+), 21 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 0/3] perf/core fixes and improvements

[Arnaldo Carvalho de Melo]

Hi Ingo,

        Please consider pulling from:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core

Regards,

- Arnaldo

Arnaldo Carvalho de Melo (2):
  perf symbols: Improve kallsyms symbol end addr calculation
  perf test: Look forward for symbol aliases

Franck Bui-Huu (1):
  perf probe: Fix wrong warning in __show_one_line() if read(1) errors
    happen

 tools/perf/builtin-test.c     |   23 ++++++++++++++---
 tools/perf/util/event.c       |    3 +-
 tools/perf/util/probe-event.c |    2 +-
 tools/perf/util/symbol.c      |   56 ++++++++++++++++++++++++++++++----------
 tools/perf/util/symbol.h      |    2 +-
 5 files changed, 65 insertions(+), 21 deletions(-)

[GIT PULL 0/3] perf/core fixes and improvements

[Arnaldo Carvalho de Melo]

Hi Ingo,

        Please pull from:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core

Regards,

- Arnaldo

Arnaldo Carvalho de Melo (3):
  perf ui browser: Return the exit key in all browsers
  perf ui browser: Add routines to compactly specify exit keys
  perf ui browser: Abstract some more slang operations

 tools/perf/builtin-annotate.c          |   17 ++--
 tools/perf/util/ui/browser.c           |   93 +++++++++++--------
 tools/perf/util/ui/browser.h           |    9 ++-
 tools/perf/util/ui/browsers/annotate.c |   37 ++++----
 tools/perf/util/ui/browsers/hists.c    |  157 ++++++++++++++------------------
 tools/perf/util/ui/browsers/map.c      |   23 ++---
 tools/perf/util/ui/util.c              |    4 +-
 tools/perf/util/util.h                 |   13 ---
 8 files changed, 161 insertions(+), 192 deletions(-)

Re: [GIT PULL 0/3] perf/core fixes and improvements

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Hi Ingo,
> 
>         Please pull from:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core
> 
> Regards,
> 
> - Arnaldo
> 
> Arnaldo Carvalho de Melo (3):
>   perf session: Free the ref_reloc_sym memory at the right place
>   perf session: Invalidate last_match when removing threads from rb_tree
>   perf tools: Don't keep unreferenced maps when unmaps are detected
> 
>  tools/perf/util/hist.c    |    2 +
>  tools/perf/util/map.c     |   49 +++++++++++++++++++++++++++++---------------
>  tools/perf/util/map.h     |   10 ++++++++-
>  tools/perf/util/session.c |    8 +++++++
>  tools/perf/util/symbol.c  |   43 +++++++++++++++++++++++++++++++++++++++
>  tools/perf/util/symbol.h  |    2 +
>  6 files changed, 96 insertions(+), 18 deletions(-)

Pulled, thanks Arnaldo!

	Ingo

[GIT PULL 0/3] perf/core fixes and improvements

[Arnaldo Carvalho de Melo]

Hi Ingo,

        Please pull from:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core

Regards,

- Arnaldo

Arnaldo Carvalho de Melo (3):
  perf session: Free the ref_reloc_sym memory at the right place
  perf session: Invalidate last_match when removing threads from rb_tree
  perf tools: Don't keep unreferenced maps when unmaps are detected

 tools/perf/util/hist.c    |    2 +
 tools/perf/util/map.c     |   49 +++++++++++++++++++++++++++++---------------
 tools/perf/util/map.h     |   10 ++++++++-
 tools/perf/util/session.c |    8 +++++++
 tools/perf/util/symbol.c  |   43 +++++++++++++++++++++++++++++++++++++++
 tools/perf/util/symbol.h  |    2 +
 6 files changed, 96 insertions(+), 18 deletions(-)

Re: [GIT PULL 0/3] perf/core fixes and improvements

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Hi Ingo,
> 
>         Please pull from:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core
> 
> Regards,
> 
> - Arnaldo
> 
> Masami Hiramatsu (3):
>   perf probe: Fix error message if get_real_path() failed
>   perf probe: Support comp_dir to find an absolute source path
>   perf probe: Fix the logic of die_compare_name
> 
>  tools/perf/util/probe-event.c  |   69 ++++++++++++++++++++++++++++
>  tools/perf/util/probe-event.h  |    1 +
>  tools/perf/util/probe-finder.c |   96 ++++++++++++++--------------------------
>  3 files changed, 103 insertions(+), 63 deletions(-)

Pulled, thanks Arnaldo!

	Ingo

[GIT PULL 0/3] perf/core fixes and improvements

[Arnaldo Carvalho de Melo]

Hi Ingo,

        Please pull from:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core

Regards,

- Arnaldo

Masami Hiramatsu (3):
  perf probe: Fix error message if get_real_path() failed
  perf probe: Support comp_dir to find an absolute source path
  perf probe: Fix the logic of die_compare_name

 tools/perf/util/probe-event.c  |   69 ++++++++++++++++++++++++++++
 tools/perf/util/probe-event.h  |    1 +
 tools/perf/util/probe-finder.c |   96 ++++++++++++++--------------------------
 3 files changed, 103 insertions(+), 63 deletions(-)