From: David Miller <davem@davemloft.net>
To: tony.luck@intel.com
Cc: torvalds@linux-foundation.org, walken@google.com,
dhowells@redhat.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: tasks getting stuck on mmap_sem?
Date: Tue, 17 Aug 2010 14:44:20 -0700 (PDT) [thread overview]
Message-ID: <20100817.144420.226783254.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTi=ZdrtWSYE0BEXJ-YDoxjta3h7RMR7Y8Z6Hu-Hc@mail.gmail.com>
From: Tony Luck <tony.luck@intel.com>
Date: Tue, 17 Aug 2010 11:24:19 -0700
> On Tue, Aug 17, 2010 at 9:14 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>> No. Looks like the rwsem changes broke sparc too. ia64 had some problems too.
>
> I did have some similar mmap_sem issues - but the combination of
> fixing the types
> of the RWSEM_* defines to be unsigned, and the return value of
> ia64_atomic64_add()
> to be "long" rather than "int" looks to have cleared up the problems I
> was seeing. I
> could generally see the hung processes in less than 10 consecutive
> kernel builds, but
> ran a few thousand builds over the weekend with no issues.
You might be triggering it via threading as well, since make uses
vfork() for running sub-jobs.
> If git is multi-threaded, it may be hitting some different code path
> ... but it isn't trivial
> for me to try this out (my systems are on an isolated lab network segment).
Like you I tried fixing atomic64, but as I mentioned it turns out
sparc64 (like powerpc) always uses a 32-bit 'int' semaphore count.
I thought perhaps that for some reason the rwsem generic code had
a dependency on 'long' so I switched sparc64's rwsems over to 'long'
counters last night too, but I still get the problem.
Even reverting the rwsem commit that added the "<" test didn't fix
things, so now I'm simply going to bisect.
next prev parent reply other threads:[~2010-08-17 21:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 4:12 David Miller
2010-08-17 16:14 ` Linus Torvalds
2010-08-17 18:24 ` Tony Luck
2010-08-17 20:46 ` Tony Luck
2010-08-17 21:08 ` Linus Torvalds
2010-08-17 21:26 ` Tony Luck
2010-08-17 21:28 ` Linus Torvalds
2010-08-17 21:47 ` Michel Lespinasse
2010-08-17 21:59 ` David Miller
2010-08-17 23:40 ` David Miller
2010-08-17 21:44 ` David Miller [this message]
2010-08-17 5:22 Dimitris Michailidis
2010-08-17 5:35 ` David Miller
2010-08-17 7:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100817.144420.226783254.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®