mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: torvalds@linux-foundation.org
Cc: tony.luck@intel.com, walken@google.com, dhowells@redhat.com,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: tasks getting stuck on mmap_sem?
Date: Tue, 17 Aug 2010 16:40:13 -0700 (PDT)	[thread overview]
Message-ID: <20100817.164013.193700583.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTikcaVKnJxC18tUcJRTQwAukYhPdWMgGGrNaVjM_@mail.gmail.com>

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Tue, 17 Aug 2010 14:28:49 -0700

> Oh, and it strikes me when looking at the sparc rwsem-const.h that it
> has some unsigned constants in it. I think
> 
>   #define RWSEM_WAITING_BIAS              0xffff0000
> 
> is actually unsigned, because it's a hex constant that doesn't fit in
> a signed int. So it's of type 'unsigned int' if I recall the C type
> rules right.

You were right all along, of course.  Nice spotting.

Something was messed up with my testing methodology last night such
that I didn't test the revert of the lib/rwsem.c changes properly.
Those actually did in fact introduce the problem.

And fixing these sparc rwsem values to be signed constants fixes the bug.

Thanks guys.

  parent reply	other threads:[~2010-08-17 23:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-17  4:12 David Miller
2010-08-17 16:14 ` Linus Torvalds
2010-08-17 18:24   ` Tony Luck
2010-08-17 20:46     ` Tony Luck
2010-08-17 21:08       ` Linus Torvalds
2010-08-17 21:26         ` Tony Luck
2010-08-17 21:28         ` Linus Torvalds
2010-08-17 21:47           ` Michel Lespinasse
2010-08-17 21:59             ` David Miller
2010-08-17 23:40           ` David Miller [this message]
2010-08-17 21:44     ` David Miller
2010-08-17  5:22 Dimitris Michailidis
2010-08-17  5:35 ` David Miller
2010-08-17  7:23 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100817.164013.193700583.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=walken@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®