* [PATCH] mmc: build fix: mmc_pm_notify is only available with CONFIG_PM=y
@ 2010-08-18 16:25 Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2010-08-18 16:25 UTC (permalink / raw)
To: lkml, torvalds, Uwe Kleine-König
Cc: Maxim Levitsky, David Brownell, Alan Stern, linux-mmc, Andrew Morton
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
This fixes a build breakage introduced by
4c2ef25 (mmc: fix all hangs related to mmc/sd card insert/removal during suspend/resume)
Cc: David Brownell <david-b@pacbell.net>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-mmc@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Acked-by: Maxim Levitsky <maximlevitsky@gmail.com>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/mmc/core/host.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
There have been 3 patches like this posted, but no one is pushing it
for merging...
diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
index 0efe631..d80cfdc 100644
--- a/drivers/mmc/core/host.c
+++ b/drivers/mmc/core/host.c
@@ -86,7 +86,9 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev)
init_waitqueue_head(&host->wq);
INIT_DELAYED_WORK(&host->detect, mmc_rescan);
INIT_DELAYED_WORK_DEFERRABLE(&host->disable, mmc_host_deeper_disable);
+#ifdef CONFIG_PM
host->pm_notify.notifier_call = mmc_pm_notify;
+#endif
/*
* By default, hosts do not support SGIO or large requests.
--
1.7.1
--
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: build fix: mmc_pm_notify is only available with CONFIG_PM=y
2010-08-13 10:01 ` Maxim Levitsky
@ 2010-08-16 7:51 ` Maxim Levitsky
0 siblings, 0 replies; 5+ messages in thread
From: Maxim Levitsky @ 2010-08-16 7:51 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: linux-kernel, David Brownell, Alan Stern, linux-mmc, Andrew Morton
On Fri, 2010-08-13 at 13:01 +0300, Maxim Levitsky wrote:
> On Fri, 2010-08-13 at 11:24 +0200, Uwe Kleine-König wrote:
> > This fixes a build breakage introduced by
> >
> > 4c2ef25 (mmc: fix all hangs related to mmc/sd card insert/removal during suspend/resume)
> >
> > Cc: Maxim Levitsky <maximlevitsky@gmail.com>
> > Cc: David Brownell <david-b@pacbell.net>
> > Cc: Alan Stern <stern@rowland.harvard.edu>
> > Cc: linux-mmc@vger.kernel.org
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > drivers/mmc/core/host.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> > index 0efe631..d80cfdc 100644
> > --- a/drivers/mmc/core/host.c
> > +++ b/drivers/mmc/core/host.c
> > @@ -86,7 +86,9 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev)
> > init_waitqueue_head(&host->wq);
> > INIT_DELAYED_WORK(&host->detect, mmc_rescan);
> > INIT_DELAYED_WORK_DEFERRABLE(&host->disable, mmc_host_deeper_disable);
> > +#ifdef CONFIG_PM
> > host->pm_notify.notifier_call = mmc_pm_notify;
> > +#endif
> >
> > /*
> > * By default, hosts do not support SGIO or large requests.
>
> Hi,
>
> Sorry about that!
Hi folks,
Sorry again for this bug.
>From now on I will test compilation rigorously.
If you need it,
Acked-by: Maxim Levitsky <maximlevitsky@gmail.com>
Best regards,
Maxim Levitsky
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] mmc: build fix: mmc_pm_notify is only available with CONFIG_PM=y
2010-08-13 9:24 ` [PATCH] mmc: build fix: mmc_pm_notify is only available with CONFIG_PM=y Uwe Kleine-König
2010-08-13 10:01 ` Maxim Levitsky
@ 2010-08-16 5:28 ` Kukjin Kim
1 sibling, 0 replies; 5+ messages in thread
From: Kukjin Kim @ 2010-08-16 5:28 UTC (permalink / raw)
To: 'Uwe Kleine-König', linux-kernel
Cc: 'Maxim Levitsky', 'David Brownell',
'Alan Stern', linux-mmc, 'Andrew Morton'
Uwe Kleine-Konig wrote:
>
> This fixes a build breakage introduced by
>
> 4c2ef25 (mmc: fix all hangs related to mmc/sd card insert/removal during
> suspend/resume)
>
> Cc: Maxim Levitsky <maximlevitsky@gmail.com>
> Cc: David Brownell <david-b@pacbell.net>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Cc: linux-mmc@vger.kernel.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> drivers/mmc/core/host.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> index 0efe631..d80cfdc 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -86,7 +86,9 @@ struct mmc_host *mmc_alloc_host(int extra, struct device
> *dev)
> init_waitqueue_head(&host->wq);
> INIT_DELAYED_WORK(&host->detect, mmc_rescan);
> INIT_DELAYED_WORK_DEFERRABLE(&host->disable,
> mmc_host_deeper_disable);
> +#ifdef CONFIG_PM
> host->pm_notify.notifier_call = mmc_pm_notify;
> +#endif
>
> /*
> * By default, hosts do not support SGIO or large requests.
> --
> 1.7.1
>
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: build fix: mmc_pm_notify is only available with CONFIG_PM=y
2010-08-13 9:24 ` [PATCH] mmc: build fix: mmc_pm_notify is only available with CONFIG_PM=y Uwe Kleine-König
@ 2010-08-13 10:01 ` Maxim Levitsky
2010-08-16 7:51 ` Maxim Levitsky
2010-08-16 5:28 ` Kukjin Kim
1 sibling, 1 reply; 5+ messages in thread
From: Maxim Levitsky @ 2010-08-13 10:01 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: linux-kernel, David Brownell, Alan Stern, linux-mmc, Andrew Morton
On Fri, 2010-08-13 at 11:24 +0200, Uwe Kleine-König wrote:
> This fixes a build breakage introduced by
>
> 4c2ef25 (mmc: fix all hangs related to mmc/sd card insert/removal during suspend/resume)
>
> Cc: Maxim Levitsky <maximlevitsky@gmail.com>
> Cc: David Brownell <david-b@pacbell.net>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Cc: linux-mmc@vger.kernel.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/mmc/core/host.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> index 0efe631..d80cfdc 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -86,7 +86,9 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev)
> init_waitqueue_head(&host->wq);
> INIT_DELAYED_WORK(&host->detect, mmc_rescan);
> INIT_DELAYED_WORK_DEFERRABLE(&host->disable, mmc_host_deeper_disable);
> +#ifdef CONFIG_PM
> host->pm_notify.notifier_call = mmc_pm_notify;
> +#endif
>
> /*
> * By default, hosts do not support SGIO or large requests.
Hi,
Sorry about that!
Best regards,
Maxim Levitsky
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] mmc: build fix: mmc_pm_notify is only available with CONFIG_PM=y
2010-06-17 21:23 [PATCH 1/2] MMC: fix all hangs related to mmc/sd card insert/removal during suspend/resume Maxim Levitsky
@ 2010-08-13 9:24 ` Uwe Kleine-König
2010-08-13 10:01 ` Maxim Levitsky
2010-08-16 5:28 ` Kukjin Kim
0 siblings, 2 replies; 5+ messages in thread
From: Uwe Kleine-König @ 2010-08-13 9:24 UTC (permalink / raw)
To: linux-kernel
Cc: Maxim Levitsky, David Brownell, Alan Stern, linux-mmc, Andrew Morton
This fixes a build breakage introduced by
4c2ef25 (mmc: fix all hangs related to mmc/sd card insert/removal during suspend/resume)
Cc: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: David Brownell <david-b@pacbell.net>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-mmc@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/mmc/core/host.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
index 0efe631..d80cfdc 100644
--- a/drivers/mmc/core/host.c
+++ b/drivers/mmc/core/host.c
@@ -86,7 +86,9 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev)
init_waitqueue_head(&host->wq);
INIT_DELAYED_WORK(&host->detect, mmc_rescan);
INIT_DELAYED_WORK_DEFERRABLE(&host->disable, mmc_host_deeper_disable);
+#ifdef CONFIG_PM
host->pm_notify.notifier_call = mmc_pm_notify;
+#endif
/*
* By default, hosts do not support SGIO or large requests.
--
1.7.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-08-18 16:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-18 16:25 [PATCH] mmc: build fix: mmc_pm_notify is only available with CONFIG_PM=y Randy Dunlap
-- strict thread matches above, loose matches on Subject: below --
2010-06-17 21:23 [PATCH 1/2] MMC: fix all hangs related to mmc/sd card insert/removal during suspend/resume Maxim Levitsky
2010-08-13 9:24 ` [PATCH] mmc: build fix: mmc_pm_notify is only available with CONFIG_PM=y Uwe Kleine-König
2010-08-13 10:01 ` Maxim Levitsky
2010-08-16 7:51 ` Maxim Levitsky
2010-08-16 5:28 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®