From: Tvrtko Ursulin <tvrtko.ursulin@sophos.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Eric Paris <eparis@redhat.com>,
Andreas Gruenbacher <agruen@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: struct fanotify_event_metadata
Date: Fri, 20 Aug 2010 10:23:07 +0100 [thread overview]
Message-ID: <201008201023.07316.tvrtko.ursulin@sophos.com> (raw)
In-Reply-To: <m3pqxd7ift.fsf@hase.home>
On Friday 20 Aug 2010 10:16:22 Andreas Schwab wrote:
> Tvrtko Ursulin <tvrtko.ursulin@sophos.com> writes:
> > Shrink pid field in the fanotify_event_metadata to 32-bit to match
> > the kernel representation. Pull mask field up since it logically
> > comes before event auxiliary data and also makes for a nicer
> > alignment.
>
> That won't buy you much wrt. alignment though, due to the packed
> attribute.
I know, it is primarily more logical ordering of fields withing the event. It
is only secondary that I thought it is nicer to have 32-32-64-32-32 than,
32-32-32-64-32, maybe there is some platform where it is nicer?
Tvrtko
Sophos Plc, The Pentagon, Abingdon Science Park, Abingdon, OX14 3YP, United Kingdom.
Company Reg No 2096520. VAT Reg No GB 348 3873 20.
next prev parent reply other threads:[~2010-08-20 9:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-14 17:44 Andreas Schwab
2010-08-19 15:44 ` Tvrtko Ursulin
2010-08-19 16:07 ` Andreas Gruenbacher
2010-08-19 16:35 ` Tvrtko Ursulin
2010-08-19 17:53 ` Eric Paris
2010-08-20 9:02 ` Tvrtko Ursulin
2010-08-20 9:16 ` Andreas Schwab
2010-08-20 9:23 ` Tvrtko Ursulin [this message]
2010-08-20 13:13 ` Eric Paris
2010-08-20 13:27 ` Andreas Schwab
2010-08-20 15:19 ` Eric Paris
2010-08-20 17:47 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008201023.07316.tvrtko.ursulin@sophos.com \
--to=tvrtko.ursulin@sophos.com \
--cc=agruen@suse.de \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome