[PATCH][resend] scripts/mod/modpost.c: fix commentary accordingly to last changes

[PATCH][resend] scripts/mod/modpost.c: fix commentary accordingly to last changes

[Andy Shevchenko]

The last commits
 37ed19d5cce35a40d3913cf9aa208ce9f60db3d7
 5003bab82d56754b27be01eef24495a02e00039d
have introduced new behaviour of sec2annotation() method. However, the
commentary inside the method was left as before. Let's fix it accordingly.

Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
 scripts/mod/modpost.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 1ec7158..33122ca 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1208,6 +1208,9 @@ static Elf_Sym *find_elf_symbol2(struct elf_info *elf, Elf_Addr addr,
  * .cpuinit.data => __cpudata
  * .memexitconst => __memconst
  * etc.
+ *
+ * The memory of returned value has been allocated on a heap. The user of this
+ * method should free it after usage.
 */
 static char *sec2annotation(const char *s)
 {
@@ -1230,7 +1233,7 @@ static char *sec2annotation(const char *s)
 			strcat(p, "data ");
 		else
 			strcat(p, " ");
-		return r; /* we leak her but we do not care */
+		return r;
 	} else {
 		return strdup("");
 	}
-- 
1.6.3.3

Re: [PATCH][resend] scripts/mod/modpost.c: fix commentary accordingly to last changes

[Américo Wang]

On Tue, Aug 17, 2010 at 01:36:40PM +0300, Andy Shevchenko wrote:
>The last commits
> 37ed19d5cce35a40d3913cf9aa208ce9f60db3d7
> 5003bab82d56754b27be01eef24495a02e00039d
>have introduced new behaviour of sec2annotation() method. However, the
>commentary inside the method was left as before. Let's fix it accordingly.
>
>Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
>Cc: Rusty Russell <rusty@rustcorp.com.au>
>Cc: Andrew Morton <akpm@linux-foundation.org>


Acked-by: WANG Cong <xiyou.wangcong@gmail.com>

>---
> scripts/mod/modpost.c |    5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
>diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
>index 1ec7158..33122ca 100644
>--- a/scripts/mod/modpost.c
>+++ b/scripts/mod/modpost.c
>@@ -1208,6 +1208,9 @@ static Elf_Sym *find_elf_symbol2(struct elf_info *elf, Elf_Addr addr,
>  * .cpuinit.data => __cpudata
>  * .memexitconst => __memconst
>  * etc.
>+ *
>+ * The memory of returned value has been allocated on a heap. The user of this
>+ * method should free it after usage.
> */
> static char *sec2annotation(const char *s)
> {
>@@ -1230,7 +1233,7 @@ static char *sec2annotation(const char *s)
> 			strcat(p, "data ");
> 		else
> 			strcat(p, " ");
>-		return r; /* we leak her but we do not care */
>+		return r;
> 	} else {
> 		return strdup("");
> 	}
>-- 
>1.6.3.3
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH][resend] scripts/mod/modpost.c: fix commentary accordingly to last changes

[Michal Marek]

On Mon, Aug 23, 2010 at 02:52:33PM +0800, Américo Wang wrote:
> On Tue, Aug 17, 2010 at 01:36:40PM +0300, Andy Shevchenko wrote:
> >The last commits
> > 37ed19d5cce35a40d3913cf9aa208ce9f60db3d7
> > 5003bab82d56754b27be01eef24495a02e00039d
> >have introduced new behaviour of sec2annotation() method. However, the
> >commentary inside the method was left as before. Let's fix it accordingly.
> >
> >Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
> >Cc: Rusty Russell <rusty@rustcorp.com.au>
> >Cc: Andrew Morton <akpm@linux-foundation.org>
> 
> 
> Acked-by: WANG Cong <xiyou.wangcong@gmail.com>

Applied, thanks.

Michal