mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Mohr <andi@lisas.de>
To: Sebastien.Hinderer@ens-lyon.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Len Brown <len.brown@intel.com>
Cc: linux-kernel@vger.kernel.org,
	Samuel Thibault <Samuel.Thibault@ens-lyon.org>
Subject: Re: [PATCH] x86: EuroBraille/Iris power off
Date: Wed, 25 Aug 2010 18:12:14 +0200	[thread overview]
Message-ID: <20100825161214.GA15087@rhlx01.hs-esslingen.de> (raw)
In-Reply-To: <20100825094925.GA3632@pema>

Hi,

excellent! Now if as the next step before inclusion you also add the usual DMI check
(as done by many drivers such as acerhdf etc.),
someone inexperienced who is dumb enough to enable it for his unrelated machine
will actually survive an otherwise raw I/O port access and poweroff vector change ;))

Unless these non-APM, non-ACPI machines don't have any DMI support
either and thus won't even have dmidecode work.....
(in which case I'd strongly suggest adding a 0x340+x port value read verification
to bail driver install in case the machine doesn't have this hardware).

Andreas Mohr

  reply	other threads:[~2010-08-25 16:12 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-25  9:49 Shérab
2010-08-25 16:12 ` Andreas Mohr [this message]
2010-08-25 21:12   ` Sebastien Hinderer
2010-08-25 21:19     ` H. Peter Anvin
2010-08-25 22:50       ` Samuel Thibault
2010-08-26  0:06         ` H. Peter Anvin
2010-08-26  0:19           ` Samuel Thibault
2010-08-26  6:45           ` Sebastien Hinderer
2010-08-26  6:55             ` H. Peter Anvin
2010-08-26  7:09               ` Andreas Mohr
2010-08-26  9:29               ` Sebastien Hinderer
2010-08-26 18:11 ` Len Brown
2010-08-26 21:08   ` Shérab
2010-08-26 21:16     ` H. Peter Anvin
2010-08-27 17:35       ` Shérab
2010-08-27 18:49         ` H. Peter Anvin
2010-08-27 22:27       ` Shérab
2010-08-29 20:59       ` Shérab
2010-09-13 10:07         ` Shérab
2010-09-13 15:10           ` Valdis.Kletnieks
2010-09-13 15:22             ` Samuel Thibault
2010-09-13 16:06               ` H. Peter Anvin
2010-09-13 16:12                 ` Samuel Thibault
2010-09-14  1:45               ` Valdis.Kletnieks
2010-09-14  5:16                 ` Shérab
2010-09-20  8:22                 ` Shérab
2010-09-26 17:54                   ` Shérab
2010-10-10 16:22                     ` Shérab
2010-11-13 19:22                       ` Shérab
2010-09-13 15:25             ` Shérab
2010-09-13 15:48               ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100825161214.GA15087@rhlx01.hs-esslingen.de \
    --to=andi@lisas.de \
    --cc=Samuel.Thibault@ens-lyon.org \
    --cc=Sebastien.Hinderer@ens-lyon.org \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®