From: Samuel Thibault <Samuel.Thibault@ens-lyon.org>
To: Valdis.Kletnieks@vt.edu
Cc: Shérab <Sebastien.Hinderer@ens-lyon.org>,
"H. Peter Anvin" <hpa@zytor.com>, "Len Brown" <lenb@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
x86@kernel.org, "Andrew Morton" <akpm@linux-foundation.org>,
"Frederic Weisbecker" <fweisbec@gmail.com>,
"Andres Salomon" <dilinger@queued.net>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: EuroBraille/Iris power off
Date: Mon, 13 Sep 2010 17:22:49 +0200 [thread overview]
Message-ID: <20100913152249.GC5364@const.bordeaux.inria.fr> (raw)
In-Reply-To: <54870.1284390647@localhost>
Valdis.Kletnieks@vt.edu, le Mon 13 Sep 2010 11:10:47 -0400, a écrit :
> On Mon, 13 Sep 2010 12:07:19 +0200, Shérab said:
>
> > +static int iris_init(void)
> > +{
> > + unsigned char status = inb(IRIS_GIO_INPUT);
> > + if (status == IRIS_GIO_NODEV) {
> > + printk(KERN_ERR "This machine does not seem to be an Iris. Power_off handler not installed.\n");
> > + return -ENODEV;
> > + }
>
> Is it actually safe to assume that this will do the right thing on a machine that
> is a non-Iris that has something *else* at that I/O address?
No.
> Any further sanity checking we can do?
No. The format of the value there is quite unknown, it's just quite sure
it won't be 0xff on the Iris.
Again, I'm not sure we really should try hard to make it automatically
detected (and thus always enabled). Having to pass a kernel parameter
to enable the functionality is completely fine, since installing Linux
on this device requires quite some tinkering already.
Samuel
next prev parent reply other threads:[~2010-09-13 15:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 9:49 Shérab
2010-08-25 16:12 ` Andreas Mohr
2010-08-25 21:12 ` Sebastien Hinderer
2010-08-25 21:19 ` H. Peter Anvin
2010-08-25 22:50 ` Samuel Thibault
2010-08-26 0:06 ` H. Peter Anvin
2010-08-26 0:19 ` Samuel Thibault
2010-08-26 6:45 ` Sebastien Hinderer
2010-08-26 6:55 ` H. Peter Anvin
2010-08-26 7:09 ` Andreas Mohr
2010-08-26 9:29 ` Sebastien Hinderer
2010-08-26 18:11 ` Len Brown
2010-08-26 21:08 ` Shérab
2010-08-26 21:16 ` H. Peter Anvin
2010-08-27 17:35 ` Shérab
2010-08-27 18:49 ` H. Peter Anvin
2010-08-27 22:27 ` Shérab
2010-08-29 20:59 ` Shérab
2010-09-13 10:07 ` Shérab
2010-09-13 15:10 ` Valdis.Kletnieks
2010-09-13 15:22 ` Samuel Thibault [this message]
2010-09-13 16:06 ` H. Peter Anvin
2010-09-13 16:12 ` Samuel Thibault
2010-09-14 1:45 ` Valdis.Kletnieks
2010-09-14 5:16 ` Shérab
2010-09-20 8:22 ` Shérab
2010-09-26 17:54 ` Shérab
2010-10-10 16:22 ` Shérab
2010-11-13 19:22 ` Shérab
2010-09-13 15:25 ` Shérab
2010-09-13 15:48 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100913152249.GC5364@const.bordeaux.inria.fr \
--to=samuel.thibault@ens-lyon.org \
--cc=Sebastien.Hinderer@ens-lyon.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=dilinger@queued.net \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®