mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: David Cross <david.cross@cypress.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] West Bridge Astoria Driver 2.6.35
Date: Mon, 30 Aug 2010 17:27:56 -0700	[thread overview]
Message-ID: <20100831002756.GA8304@kroah.com> (raw)
In-Reply-To: <1281140943.4035.7.camel@odc-laptop>

On Fri, Aug 06, 2010 at 05:29:03PM -0700, David Cross wrote:
> Re-Re-Re-Re-Re-sending with unnecessary files removed, line wrap turned off in
> new email client, Signed-off-by included in the correct place, and TODO file added.

I get a build error when I try to build this driver:
	drivers/staging/westbridge/astoria/block/../include/linux/westbridge/cyasmisc.h:521:2: error: expected declaration specifiers or ‘...’ before ‘cy_as_hal_device_tag’

It looks like the #include mess isn't working quite properly.

Also note that this driver is building on an x86-64 platform, which is
something that you probably don't want :)

So, for now, I'll just mark the driver as CONFIG_BROKEN and can you send
me some Kconfig patches against the next linux-next release which should
have this driver in it, so that it will build properly?

thanks,

greg k-h

  parent reply	other threads:[~2010-08-31  0:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1281140943.4035.7.camel@odc-laptop>
2010-08-07  0:33 ` Greg KH
2010-08-31  0:27 ` Greg KH [this message]
2010-08-31 16:17   ` David Cross
2010-08-31 16:32     ` Greg KH
     [not found] <1281137016.3986.8.camel@odc-laptop>
2010-08-07  0:16 ` Greg KH
2010-08-07  0:53   ` David Cross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100831002756.GA8304@kroah.com \
    --to=greg@kroah.com \
    --cc=david.cross@cypress.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome