Re: [PATCH] West Bridge Astoria Driver 2.6.35

[Greg KH <greg@kroah.com>]

On Tue, Aug 31, 2010 at 09:17:18AM -0700, David Cross wrote:
> 
> > I get a build error when I try to build this driver:
> >
> drivers/staging/westbridge/astoria/block/../include/linux/westbridge/c>
> yasmisc.h:521:2: error: expected declaration specifiers or '...' before  >
> 'cy_as_hal_device_tag'
> 
> > It looks like the #include mess isn't working quite properly.
> 
> > Also note that this driver is building on an x86-64 platform, which is
> > something that you probably don't want :)
> 
> > So, for now, I'll just mark the driver as CONFIG_BROKEN and can you send
> > me some Kconfig patches against the next linux-next release which should
> > have this driver in it, so that it will build properly?
> 
> Sure, I can do that. I have since changed the Kconfig structure a bit. It
> actually will build properly with the correct .config as it is though. I can
> send you the .config if you would like.

It's up to the Kconfig rules to ensure that there can never be a
"non-correct" .config file, so that needs to be fixed so that the build
will never be broken no matter what type of options are selected.

Care to send a patch for that?

thanks,

greg k-h