mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Gunnar Gudvardarson <gunni@wave.is>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: crystalhd: crystalhd_cmds: fixed a brace issue
Date: Tue, 31 Aug 2010 15:05:06 -0700	[thread overview]
Message-ID: <20100831220506.GA21191@kroah.com> (raw)
In-Reply-To: <1282162206-9524-1-git-send-email-gunni@wave.is>

On Wed, Aug 18, 2010 at 08:10:06PM +0000, Gunnar Gudvardarson wrote:
> Fixed a brace issue.
> 
> Signed-off-by: Gunnar Gudvardarson <gunni@wave.is>
> ---
>  drivers/staging/crystalhd/crystalhd_cmds.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/crystalhd/crystalhd_cmds.c b/drivers/staging/crystalhd/crystalhd_cmds.c
> index 1429608..d423775 100644
> --- a/drivers/staging/crystalhd/crystalhd_cmds.c
> +++ b/drivers/staging/crystalhd/crystalhd_cmds.c
> @@ -309,9 +309,9 @@ static enum BC_STATUS bc_cproc_download_fw(struct crystalhd_cmd *ctx,
>  	sts = crystalhd_download_fw(ctx->adp, (uint8_t *)idata->add_cdata,
>  				  idata->add_cdata_sz);
>  
> -	if (sts != BC_STS_SUCCESS) {
> +	if (sts != BC_STS_SUCCESS)
>  		BCMLOG_ERR("Firmware Download Failure!! - %d\n", sts);
> -	} else
> +	else

This breaks the build, are you sure you tested it after making the
patch?

thanks,

greg k-h

      reply	other threads:[~2010-08-31 22:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-18 20:10 Gunnar Gudvardarson
2010-08-31 22:05 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100831220506.GA21191@kroah.com \
    --to=greg@kroah.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=gunni@wave.is \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome