* [PATCH] Staging: crystalhd: crystalhd_cmds: fixed a brace issue
@ 2010-08-18 20:10 Gunnar Gudvardarson
2010-08-31 22:05 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Gunnar Gudvardarson @ 2010-08-18 20:10 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Gunnar Gudvardarson
Fixed a brace issue.
Note: checkpatch was clean until i ran format-patch, which added 3
trailing whitespaces.
Signed-off-by: Gunnar Gudvardarson <gunni@wave.is>
---
drivers/staging/crystalhd/crystalhd_cmds.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/crystalhd/crystalhd_cmds.c b/drivers/staging/crystalhd/crystalhd_cmds.c
index 1429608..d423775 100644
--- a/drivers/staging/crystalhd/crystalhd_cmds.c
+++ b/drivers/staging/crystalhd/crystalhd_cmds.c
@@ -309,9 +309,9 @@ static enum BC_STATUS bc_cproc_download_fw(struct crystalhd_cmd *ctx,
sts = crystalhd_download_fw(ctx->adp, (uint8_t *)idata->add_cdata,
idata->add_cdata_sz);
- if (sts != BC_STS_SUCCESS) {
+ if (sts != BC_STS_SUCCESS)
BCMLOG_ERR("Firmware Download Failure!! - %d\n", sts);
- } else
+ else
ctx->state |= BC_LINK_INIT;
return sts;
--
1.7.0.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: crystalhd: crystalhd_cmds: fixed a brace issue
2010-08-18 20:10 [PATCH] Staging: crystalhd: crystalhd_cmds: fixed a brace issue Gunnar Gudvardarson
@ 2010-08-31 22:05 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2010-08-31 22:05 UTC (permalink / raw)
To: Gunnar Gudvardarson; +Cc: gregkh, devel, linux-kernel
On Wed, Aug 18, 2010 at 08:10:06PM +0000, Gunnar Gudvardarson wrote:
> Fixed a brace issue.
>
> Signed-off-by: Gunnar Gudvardarson <gunni@wave.is>
> ---
> drivers/staging/crystalhd/crystalhd_cmds.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/crystalhd/crystalhd_cmds.c b/drivers/staging/crystalhd/crystalhd_cmds.c
> index 1429608..d423775 100644
> --- a/drivers/staging/crystalhd/crystalhd_cmds.c
> +++ b/drivers/staging/crystalhd/crystalhd_cmds.c
> @@ -309,9 +309,9 @@ static enum BC_STATUS bc_cproc_download_fw(struct crystalhd_cmd *ctx,
> sts = crystalhd_download_fw(ctx->adp, (uint8_t *)idata->add_cdata,
> idata->add_cdata_sz);
>
> - if (sts != BC_STS_SUCCESS) {
> + if (sts != BC_STS_SUCCESS)
> BCMLOG_ERR("Firmware Download Failure!! - %d\n", sts);
> - } else
> + else
This breaks the build, are you sure you tested it after making the
patch?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-31 22:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-18 20:10 [PATCH] Staging: crystalhd: crystalhd_cmds: fixed a brace issue Gunnar Gudvardarson
2010-08-31 22:05 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome