mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: "Sascha Hauer" <s.hauer@pengutronix.de>,
	"Linus Walleij" <linus.ml.walleij@gmail.com>,
	"Dan Williams" <dan.j.williams@intel.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH 3/3 v2] dmaengine: Add Freescale i.MX SDMA support
Date: Thu, 2 Sep 2010 12:20:19 +0100	[thread overview]
Message-ID: <20100902112019.GZ26319@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <201008281830.05208.marek.vasut@gmail.com>

On Sat, Aug 28, 2010 at 06:30:05PM +0200, Marek Vasut wrote:
> Dne So 28. srpna 2010 18:18:58 Sascha Hauer napsal(a):
> > Nope, this has nothing to do with static mappings vs. ioremap. The
> > difference is that read[b,w,l] do little endian accesses suitable for
> > PCI whereas the __raw_* functions do accesses in CPU endianess.
> > Peripherals integrated into a SoC like the SDMA engine here are
> > normally accessible in native endianess and thus need the __raw_*
> > functions. An external network controller (for example a LAN9117) will
> > probably need the non raw functions. Note that 99% of the arm users use
> > little endian only and thus cpu_to_le* is a noop, so both types will work
> > for most people.
> 
> Sorry, you got me here. Why do we have io{read,write} then btw. ? That's for 
> x86's io space, right ?

io{read,write} are for use with ioremap/ioport_map, and allow drivers to
be written which can access registers via MMIO or the PC IO space.

If your driver doesn't support the PC IO space (iow, doesn't use
ioport_map) there's no point using the io{read,write} APIs.

Also note that there's one very big difference between read[bwl] and
__raw_read[bwl].  The former have a barrier to ensure correct ordering
for drivers doing DMA, the latter do not.  So if you use the latter and
you care about data being visible to a DMA agent, you have to ensure
you have proper barriers in place.

  parent reply	other threads:[~2010-09-02 11:20 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-16 11:07 [RFC] dmaengine: assorted patches and Freescale " Sascha Hauer
2010-08-16 11:07 ` [PATCH 1/3] dmaengine: add possibility for cyclic transfers Sascha Hauer
2010-08-16 11:56   ` Lothar Waßmann
2010-08-16 12:27     ` Linus Walleij
2010-08-16 12:32     ` Sascha Hauer
2010-08-16 12:22   ` Linus Walleij
2010-09-20 13:01   ` Sascha Hauer
2010-09-23 19:42     ` Dan Williams
2010-09-24  7:25       ` Sascha Hauer
2010-08-16 11:07 ` [PATCH 2/3] dmaengine: add wrapper functions for dmaengine Sascha Hauer
2010-08-23  7:17   ` Sascha Hauer
2010-09-20 13:02   ` Sascha Hauer
2010-09-23 19:53   ` Dan Williams
2010-09-24  7:25     ` Sascha Hauer
2010-09-24 15:45       ` Dan Williams
2010-08-16 11:07 ` [PATCH 3/3] dmaengine: Add Freescale i.MX SDMA support Sascha Hauer
2010-08-16 12:21   ` Linus Walleij
2010-08-16 14:15     ` Sascha Hauer
2010-08-17  4:36       ` Baruch Siach
2010-08-17  6:47         ` Sascha Hauer
2010-08-18 11:17           ` Philippe Rétornaz
2010-08-24  7:10     ` [PATCH 3/3 v3] " Sascha Hauer
2010-09-02 14:06     ` [PATCH 3/3] " Russell King - ARM Linux
2010-08-23 12:57   ` [PATCH 3/3 v2] " Sascha Hauer
2010-08-23 17:30     ` Linus Walleij
2010-08-24  6:58       ` Sascha Hauer
2010-08-23 17:48     ` Uwe Kleine-König
2010-08-28 15:18       ` Linus Walleij
2010-08-28 15:27         ` Marek Vasut
2010-08-28 16:18           ` Sascha Hauer
2010-08-28 16:30             ` Marek Vasut
2010-08-28 17:20               ` Sascha Hauer
2010-09-02 11:20               ` Russell King - ARM Linux [this message]
2010-08-29 12:35             ` Linus Walleij
2010-08-30 12:55               ` Sascha Hauer
2010-08-24  7:58     ` Lothar Waßmann
2010-08-24 15:01       ` Linus Walleij
2010-08-27 12:22   ` [PATCH 3/3 v3] " Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100902112019.GZ26319@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=dan.j.williams@intel.com \
    --cc=linus.ml.walleij@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek.vasut@gmail.com \
    --cc=s.hauer@pengutronix.de \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®