From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Linus Walleij <linus.ml.walleij@gmail.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Dan Williams <dan.j.williams@intel.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] dmaengine: Add Freescale i.MX SDMA support
Date: Thu, 2 Sep 2010 15:06:30 +0100 [thread overview]
Message-ID: <20100902140630.GM26319@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <AANLkTi=pO-ZJ33FrL=4bVRYa2o9HA0_h5tBYG7wdMuwz@mail.gmail.com>
On Mon, Aug 16, 2010 at 02:21:06PM +0200, Linus Walleij wrote:
> > +/*
> > + * Buffer descriptor
> > + */
> > +struct sdma_buffer_descriptor {
> > + struct sdma_mode_count mode;
> > + u32 buffer_addr; /* address of the buffer described */
> > + u32 ext_buffer_addr; /* extended buffer address */
>
> Shouldn't these be dma_addr_t? OK that's probably u32
> anyway but just to make a marker...
If this is describing hardware, then it makes sense to use uNN rather
than dma_addr_t. dma_addr_t may be subject to change in the future.
next prev parent reply other threads:[~2010-09-02 14:06 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 11:07 [RFC] dmaengine: assorted patches and Freescale " Sascha Hauer
2010-08-16 11:07 ` [PATCH 1/3] dmaengine: add possibility for cyclic transfers Sascha Hauer
2010-08-16 11:56 ` Lothar Waßmann
2010-08-16 12:27 ` Linus Walleij
2010-08-16 12:32 ` Sascha Hauer
2010-08-16 12:22 ` Linus Walleij
2010-09-20 13:01 ` Sascha Hauer
2010-09-23 19:42 ` Dan Williams
2010-09-24 7:25 ` Sascha Hauer
2010-08-16 11:07 ` [PATCH 2/3] dmaengine: add wrapper functions for dmaengine Sascha Hauer
2010-08-23 7:17 ` Sascha Hauer
2010-09-20 13:02 ` Sascha Hauer
2010-09-23 19:53 ` Dan Williams
2010-09-24 7:25 ` Sascha Hauer
2010-09-24 15:45 ` Dan Williams
2010-08-16 11:07 ` [PATCH 3/3] dmaengine: Add Freescale i.MX SDMA support Sascha Hauer
2010-08-16 12:21 ` Linus Walleij
2010-08-16 14:15 ` Sascha Hauer
2010-08-17 4:36 ` Baruch Siach
2010-08-17 6:47 ` Sascha Hauer
2010-08-18 11:17 ` Philippe Rétornaz
2010-08-24 7:10 ` [PATCH 3/3 v3] " Sascha Hauer
2010-09-02 14:06 ` Russell King - ARM Linux [this message]
2010-08-23 12:57 ` [PATCH 3/3 v2] " Sascha Hauer
2010-08-23 17:30 ` Linus Walleij
2010-08-24 6:58 ` Sascha Hauer
2010-08-23 17:48 ` Uwe Kleine-König
2010-08-28 15:18 ` Linus Walleij
2010-08-28 15:27 ` Marek Vasut
2010-08-28 16:18 ` Sascha Hauer
2010-08-28 16:30 ` Marek Vasut
2010-08-28 17:20 ` Sascha Hauer
2010-09-02 11:20 ` Russell King - ARM Linux
2010-08-29 12:35 ` Linus Walleij
2010-08-30 12:55 ` Sascha Hauer
2010-08-24 7:58 ` Lothar Waßmann
2010-08-24 15:01 ` Linus Walleij
2010-08-27 12:22 ` [PATCH 3/3 v3] " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902140630.GM26319@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=dan.j.williams@intel.com \
--cc=linus.ml.walleij@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome