From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
To: cernekee@gmail.com
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] MIPS: Move FIXADDR_TOP into spaces.h
Date: Tue, 07 Sep 2010 22:13:07 +0900 (JST) [thread overview]
Message-ID: <20100907.221307.39158422.anemo@mba.ocn.ne.jp> (raw)
In-Reply-To: <d84f0a8caeb61c388b1145f89c879de3@localhost>
On Mon, 6 Sep 2010 21:03:52 -0700, Kevin Cernekee <cernekee@gmail.com> wrote:
> -#define FIXADDR_TOP ((unsigned long)(long)(int)0xfffe0000)
...
> +#define FIXADDR_TOP _AC(0xfffe0000, UL)
For 64-bit kernel, FIXADDR_TOP should be 0xfffffffffffe0000UL not
0x00000000fffe0000UL.
The magical casts are used to sign-extend the address. Please do not
drop them.
---
Atsushi Nemoto
prev parent reply other threads:[~2010-09-07 13:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 4:03 Kevin Cernekee
2010-09-07 13:13 ` Atsushi Nemoto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100907.221307.39158422.anemo@mba.ocn.ne.jp \
--to=anemo@mba.ocn.ne.jp \
--cc=cernekee@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®