From: Andrew Morton <akpm@linux-foundation.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: David Woodhouse <David.Woodhouse@intel.com>,
linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ihex: Add support for CS:IP/EIP records
Date: Wed, 15 Sep 2010 14:27:44 -0700 [thread overview]
Message-ID: <20100915142744.ee5bb928.akpm@linux-foundation.org> (raw)
In-Reply-To: <1284039626-30394-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Thu, 9 Sep 2010 14:40:26 +0100
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> + data32 = &record->data[0];
> + *data32 = htonl(*data32);
firmware/ihex2fw.c: In function 'process_ihex':
firmware/ihex2fw.c:231: warning: assignment from incompatible pointer type
And afacit data[] isn't 32-bit aligned and I don't know that all
architectures support htonl() against a misaligned pointer.
I'll drop the patch.
next prev parent reply other threads:[~2010-09-15 21:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 13:40 Mark Brown
2010-09-11 8:29 ` David Woodhouse
2010-09-11 10:06 ` Mark Brown
2010-09-15 21:27 ` Andrew Morton [this message]
2010-09-16 10:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100915142744.ee5bb928.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=David.Woodhouse@intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome