From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Woodhouse <David.Woodhouse@intel.com>,
linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ihex: Add support for CS:IP/EIP records
Date: Thu, 16 Sep 2010 11:41:55 +0100 [thread overview]
Message-ID: <20100916104155.GB7837@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20100915142744.ee5bb928.akpm@linux-foundation.org>
On Wed, Sep 15, 2010 at 02:27:44PM -0700, Andrew Morton wrote:
> Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> > + data32 = &record->data[0];
> > + *data32 = htonl(*data32);
> firmware/ihex2fw.c: In function 'process_ihex':
> firmware/ihex2fw.c:231: warning: assignment from incompatible pointer type
Which architecture are you using - my AMD64 system isn't noticing these
things for me?
> And afacit data[] isn't 32-bit aligned and I don't know that all
> architectures support htonl() against a misaligned pointer.
We're pretty much safe in userspace, if the hardware doesn't support it
then as far as I'm aware pretty much all OSs do a software fixup. This
isn't great for performance but works.
> I'll drop the patch.
OK, I'll spin it later today.
prev parent reply other threads:[~2010-09-16 10:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 13:40 Mark Brown
2010-09-11 8:29 ` David Woodhouse
2010-09-11 10:06 ` Mark Brown
2010-09-15 21:27 ` Andrew Morton
2010-09-16 10:41 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916104155.GB7837@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=David.Woodhouse@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome