From: Thomas Renninger <trenn@suse.de>
To: Jean Pihet <jean.pihet@newoldbits.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Arjan van de Ven <arjan@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Len Brown <len.brown@intel.com>,
arjan@infradead.org, Kevin Hilman <khilman@deeprootsystems.com>,
linux-kernel@vger.kernel.org, discuss@lesswatts.org,
linux-pm@lists.linux-foundation.org, linux-omap@vger.kernel.org,
linux-perf-users@vger.kernel.org,
linux-trace-users@vger.kernel.org
Subject: Re: [PATCH] tracing, perf: add more power related events
Date: Sat, 18 Sep 2010 00:17:03 +0200 [thread overview]
Message-ID: <201009180017.03821.trenn@suse.de> (raw)
In-Reply-To: <AANLkTi=W_Lo2m=hkA2F48oUziqGzt4Tr8y6KhfgqRnbz@mail.gmail.com>
DO NOT APPLY THIS ONE!!!
The others should go into a mainline tree if Jean is ok with them.
This one does not work, due to some include dependencies or whatever
else I can't see right now.
The idea: Provide old trace power interfaces via .config option to not break
existing perf/powertop/.. binaries.
Not sure whether it's worth looking at it further. It shouldn't be needed...
Thomas
---
include/trace/events/power.h | 11 +++++++++++
kernel/trace/Kconfig | 4 ++++
2 files changed, 15 insertions(+)
Index: linux-2.6.35-master/kernel/trace/Kconfig
===================================================================
--- linux-2.6.35-master.orig/kernel/trace/Kconfig
+++ linux-2.6.35-master/kernel/trace/Kconfig
@@ -64,6 +64,10 @@ config EVENT_TRACING
select CONTEXT_SWITCH_TRACER
bool
+config DEPRECATED_POWER_EVENT_TRACING
+ bool
+ default n
+
config CONTEXT_SWITCH_TRACER
bool
Index: linux-2.6.35-master/include/trace/events/power.h
===================================================================
--- linux-2.6.35-master.orig/include/trace/events/power.h
+++ linux-2.6.35-master/include/trace/events/power.h
@@ -50,6 +50,7 @@ DEFINE_EVENT(power, power_switch_state,
TP_ARGS(type, state, cpu_id)
);
+#ifdef CONFIG_DEPRECATED_POWER_EVENT_TRACING
DEFINE_EVENT(power, power_start,
TP_PROTO(unsigned int type, unsigned int state, unsigned int cpu_id),
@@ -81,6 +82,16 @@ TRACE_EVENT(power_end,
TP_printk("cpu_id=%lu", (unsigned long)__entry->cpu_id)
);
+#else
+inline void trace_power_end(unsigned int cpu_id)
+{}
+inline void trace_power_start(unsigned int type, unsigned int state,
+ unsigned int cpu_id)
+{}
+inline void trace_power_frequency(unsigned int type, unsigned int state,
+ unsigned int cpu_id)
+{}
+#endif
/*
* The clock events are used for clock enable/disable and for
next prev parent reply other threads:[~2010-09-17 22:17 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 7:21 Jean Pihet
2010-09-07 8:01 ` Jean Pihet
2010-09-08 6:53 ` Ingo Molnar
2010-09-09 7:15 ` Jean Pihet
2010-09-09 7:54 ` Ingo Molnar
2010-09-15 15:45 ` Jean Pihet
2010-09-17 13:08 ` Thomas Renninger
2010-09-17 14:05 ` Jean Pihet
2010-09-17 14:24 ` Ingo Molnar
2010-09-17 15:36 ` Thomas Renninger
2010-09-17 16:24 ` Ingo Molnar
2010-09-17 22:26 ` Thomas Renninger
2010-09-22 15:31 ` Jean Pihet
2010-09-22 15:33 ` Arjan van de Ven
2010-09-22 15:36 ` Jean Pihet
2010-09-22 16:32 ` Arjan van de Ven
2010-09-22 16:43 ` Peter Zijlstra
2010-09-22 17:06 ` Arjan van de Ven
2010-09-22 17:30 ` Peter Zijlstra
2010-09-22 18:15 ` Steven Rostedt
2010-09-22 18:23 ` Ingo Molnar
2010-09-22 18:30 ` Peter Zijlstra
2010-09-22 18:26 ` Peter Zijlstra
2010-09-22 18:36 ` Steven Rostedt
2010-09-22 18:43 ` Peter Zijlstra
2010-09-22 19:14 ` Frank Ch. Eigler
2010-09-22 17:36 ` Thomas Renninger
2010-09-22 16:47 ` Peter Zijlstra
2010-09-22 17:57 ` Thomas Renninger
2010-09-22 18:13 ` Arjan van de Ven
2010-09-22 18:34 ` Thomas Renninger
2010-09-22 18:09 ` Rafael J. Wysocki
2010-09-22 18:49 ` Rafael J. Wysocki
2010-09-28 8:35 ` Jean Pihet
2010-09-28 21:22 ` Rafael J. Wysocki
2010-09-28 21:43 ` Jean Pihet
2010-09-28 22:05 ` Rafael J. Wysocki
2010-09-28 21:45 ` Arjan van de Ven
2010-09-28 22:05 ` Rafael J. Wysocki
2010-09-29 7:49 ` Thomas Renninger
2010-09-29 9:25 ` Jean Pihet
2010-10-04 17:55 ` [linux-pm] " Pavel Machek
2010-09-17 15:29 ` Thomas Renninger
2010-09-17 21:58 ` Thomas Renninger
2010-09-17 22:04 ` Thomas Renninger
2010-09-17 22:10 ` Thomas Renninger
2010-09-17 22:17 ` Thomas Renninger [this message]
2010-09-17 8:28 ` [tip:perf/core] tracing, perf: Add " tip-bot for Jean Pihet
-- strict thread matches above, loose matches on Subject: below --
2010-08-16 11:09 [PATCH] tracing, perf: add " Jean Pihet
2010-08-16 11:15 ` Peter Zijlstra
2010-08-16 11:25 ` Jean Pihet
2010-08-23 10:25 ` Jean Pihet
2010-09-03 17:00 ` Jean Pihet
2010-09-03 18:05 ` Thomas Renninger
2010-09-03 19:55 ` Ingo Molnar
2010-09-03 20:10 ` Thomas Renninger
2010-09-03 20:28 ` Ingo Molnar
2010-09-03 22:56 ` Arjan van de Ven
2010-09-04 8:18 ` Ingo Molnar
2010-09-06 8:56 ` Jean Pihet
2010-09-06 10:42 ` Thomas Renninger
2010-09-06 11:27 ` Jean Pihet
2010-09-06 12:00 ` Thomas Renninger
2010-09-07 7:28 ` Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009180017.03821.trenn@suse.de \
--to=trenn@suse.de \
--cc=arjan@infradead.org \
--cc=arjan@linux.intel.com \
--cc=discuss@lesswatts.org \
--cc=jean.pihet@newoldbits.com \
--cc=khilman@deeprootsystems.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-trace-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome