Re: [PATCH] PCI / PCIe / AER: Disable native AER service if BIOS has precedence (v2) (was: Re: [PATCH] PCI / PCIe / AER ...)

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Saturday, September 25, 2010, Huang Ying wrote:
> Hi, Rafael,
> 
> On Tue, 2010-09-21 at 00:50 +0800, Rafael J. Wysocki wrote:
> > --- linux-2.6.orig/drivers/pci/pcie/portdrv_acpi.c
> > +++ linux-2.6/drivers/pci/pcie/portdrv_acpi.c
> > @@ -49,7 +49,7 @@ int pcie_port_acpi_setup(struct pci_dev 
> >  		| OSC_PCI_EXPRESS_PME_CONTROL;
> >  
> >  	if (pci_aer_available()) {
> > -		if (pcie_aer_get_firmware_first(port))
> > +		if (aer_acpi_firmware_first())
> >  			dev_dbg(&port->dev, "PCIe errors handled by BIOS.\n");
> >  		else
> >  			flags |= OSC_PCI_EXPRESS_AER_CONTROL;
> 
> The original per-device firmware_first is overridden by the new global
> firmware_first? If it is, why keep the original per-device
> firmware_first?

I didn't want to remove it just yet, but I do think it should be removed.

Rafael