mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Huang Ying <ying.huang@intel.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Chen Gong <gong.chen@linux.intel.com>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] PCI / PCIe / AER: Disable native AER service if BIOS has precedence (v2) (was: Re: [PATCH]  PCI / PCIe / AER ...)
Date: Sat, 25 Sep 2010 13:51:02 +0800	[thread overview]
Message-ID: <1285393862.15685.37.camel@yhuang-dev> (raw)
In-Reply-To: <201009201850.00626.rjw@sisk.pl>

Hi, Rafael,

On Tue, 2010-09-21 at 00:50 +0800, Rafael J. Wysocki wrote:
> --- linux-2.6.orig/drivers/pci/pcie/portdrv_acpi.c
> +++ linux-2.6/drivers/pci/pcie/portdrv_acpi.c
> @@ -49,7 +49,7 @@ int pcie_port_acpi_setup(struct pci_dev 
>  		| OSC_PCI_EXPRESS_PME_CONTROL;
>  
>  	if (pci_aer_available()) {
> -		if (pcie_aer_get_firmware_first(port))
> +		if (aer_acpi_firmware_first())
>  			dev_dbg(&port->dev, "PCIe errors handled by BIOS.\n");
>  		else
>  			flags |= OSC_PCI_EXPRESS_AER_CONTROL;

The original per-device firmware_first is overridden by the new global
firmware_first? If it is, why keep the original per-device
firmware_first?

Best Regards,
Huang Ying



  parent reply	other threads:[~2010-09-25  5:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-19 22:02 [PATCH] PCI / PCIe / AER: Disable native AER service if BIOS has precedence Rafael J. Wysocki
2010-09-20  6:18 ` Chen Gong
2010-09-20 16:50   ` [PATCH] PCI / PCIe / AER: Disable native AER service if BIOS has precedence (v2) (was: Re: [PATCH] PCI / PCIe / AER ...) Rafael J. Wysocki
2010-09-24 16:53     ` Jesse Barnes
2010-09-25  5:51     ` Huang Ying [this message]
2010-09-25 20:37       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285393862.15685.37.camel@yhuang-dev \
    --to=ying.huang@intel.com \
    --cc=gong.chen@linux.intel.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=rjw@sisk.pl \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®