* [PATCH] mrst_max3110: Missing linux/irq.h include.
@ 2010-09-29 4:36 David Miller
2010-09-29 10:00 ` Alan Cox
2010-09-29 18:44 ` Tang, Feng
0 siblings, 2 replies; 3+ messages in thread
From: David Miller @ 2010-09-29 4:36 UTC (permalink / raw)
To: gregkh; +Cc: feng.tang, linux-kernel
This driver makes use of IRQ_TYPE_EDGE_FALLING, therefore it must
include linux/irq.h
drivers/serial/mrst_max3110.c: In function 'serial_m3110_startup':
drivers/serial/mrst_max3110.c:470:5: error: 'IRQ_TYPE_EDGE_FALLING' undeclared (first use in this function)
drivers/serial/mrst_max3110.c:470:5: note: each undeclared identifier is reported only once for each function it appears in
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/serial/mrst_max3110.c b/drivers/serial/mrst_max3110.c
index f6ad1ec..915dedc 100644
--- a/drivers/serial/mrst_max3110.c
+++ b/drivers/serial/mrst_max3110.c
@@ -33,6 +33,7 @@
#include <linux/console.h>
#include <linux/sysrq.h>
#include <linux/platform_device.h>
+#include <linux/irq.h>
#include <linux/tty.h>
#include <linux/tty_flip.h>
#include <linux/serial_core.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mrst_max3110: Missing linux/irq.h include.
2010-09-29 4:36 [PATCH] mrst_max3110: Missing linux/irq.h include David Miller
@ 2010-09-29 10:00 ` Alan Cox
2010-09-29 18:44 ` Tang, Feng
1 sibling, 0 replies; 3+ messages in thread
From: Alan Cox @ 2010-09-29 10:00 UTC (permalink / raw)
To: David Miller; +Cc: gregkh, feng.tang, linux-kernel
On Tue, 28 Sep 2010 21:36:20 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
>
> This driver makes use of IRQ_TYPE_EDGE_FALLING, therefore it must
> include linux/irq.h
>
> drivers/serial/mrst_max3110.c: In function 'serial_m3110_startup':
> drivers/serial/mrst_max3110.c:470:5: error: 'IRQ_TYPE_EDGE_FALLING' undeclared (first use in this function)
> drivers/serial/mrst_max3110.c:470:5: note: each undeclared identifier is reported only once for each function it appears in
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
Acked-by: Alan Cox <alan@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] mrst_max3110: Missing linux/irq.h include.
2010-09-29 4:36 [PATCH] mrst_max3110: Missing linux/irq.h include David Miller
2010-09-29 10:00 ` Alan Cox
@ 2010-09-29 18:44 ` Tang, Feng
1 sibling, 0 replies; 3+ messages in thread
From: Tang, Feng @ 2010-09-29 18:44 UTC (permalink / raw)
To: David Miller, gregkh; +Cc: linux-kernel
Looks good to me, thanks for fixing it.
- Feng
-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Tuesday, September 28, 2010 11:36 PM
To: gregkh@suse.de
Cc: Tang, Feng; linux-kernel@vger.kernel.org
Subject: [PATCH] mrst_max3110: Missing linux/irq.h include.
This driver makes use of IRQ_TYPE_EDGE_FALLING, therefore it must
include linux/irq.h
drivers/serial/mrst_max3110.c: In function 'serial_m3110_startup':
drivers/serial/mrst_max3110.c:470:5: error: 'IRQ_TYPE_EDGE_FALLING' undeclared (first use in this function)
drivers/serial/mrst_max3110.c:470:5: note: each undeclared identifier is reported only once for each function it appears in
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/serial/mrst_max3110.c b/drivers/serial/mrst_max3110.c
index f6ad1ec..915dedc 100644
--- a/drivers/serial/mrst_max3110.c
+++ b/drivers/serial/mrst_max3110.c
@@ -33,6 +33,7 @@
#include <linux/console.h>
#include <linux/sysrq.h>
#include <linux/platform_device.h>
+#include <linux/irq.h>
#include <linux/tty.h>
#include <linux/tty_flip.h>
#include <linux/serial_core.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-29 18:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-29 4:36 [PATCH] mrst_max3110: Missing linux/irq.h include David Miller
2010-09-29 10:00 ` Alan Cox
2010-09-29 18:44 ` Tang, Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome