mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] MN10300: Handle missing sys_cacheflush() when caching disabled [ver #2]
@ 2010-09-29  0:57 David Howells
  0 siblings, 0 replies; only message in thread
From: David Howells @ 2010-09-29  0:57 UTC (permalink / raw)
  To: torvalds, akpm, msalter; +Cc: linux-am33-list, linux-kernel, David Howells

When caching is disabled on the MN10300 arch, the sys_cacheflush() function is
removed by conditional stuff in the makefiles, but is still referred to by the
syscall table.

Provide a null version that just returns 0 when caching is disabled (or -EINVAL
if the arguments are silly).

Signed-off-by: David Howells <dhowells@redhat.com>
---

 arch/mn10300/mm/Makefile         |   14 ++++++--------
 arch/mn10300/mm/cache-disabled.c |   21 +++++++++++++++++++++
 2 files changed, 27 insertions(+), 8 deletions(-)
 create mode 100644 arch/mn10300/mm/cache-disabled.c


diff --git a/arch/mn10300/mm/Makefile b/arch/mn10300/mm/Makefile
index 28b9d98..1557277 100644
--- a/arch/mn10300/mm/Makefile
+++ b/arch/mn10300/mm/Makefile
@@ -2,13 +2,11 @@
 # Makefile for the MN10300-specific memory management code
 #
 
+cacheflush-y	:= cache.o cache-mn10300.o
+cacheflush-$(CONFIG_MN10300_CACHE_WBACK) += cache-flush-mn10300.o
+
+cacheflush-$(CONFIG_MN10300_CACHE_DISABLED) := cache-disabled.o
+
 obj-y := \
 	init.o fault.o pgtable.o extable.o tlb-mn10300.o mmu-context.o \
-	misalignment.o dma-alloc.o
-
-ifneq ($(CONFIG_MN10300_CACHE_DISABLED),y)
-obj-y	+= cache.o cache-mn10300.o
-ifeq ($(CONFIG_MN10300_CACHE_WBACK),y)
-obj-y	+= cache-flush-mn10300.o
-endif
-endif
+	misalignment.o dma-alloc.o $(cacheflush-y)
diff --git a/arch/mn10300/mm/cache-disabled.c b/arch/mn10300/mm/cache-disabled.c
new file mode 100644
index 0000000..f669ea4
--- /dev/null
+++ b/arch/mn10300/mm/cache-disabled.c
@@ -0,0 +1,21 @@
+/* Handle the cache being disabled
+ *
+ * Copyright (C) 2010 Red Hat, Inc. All Rights Reserved.
+ * Written by David Howells (dhowells@redhat.com)
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public Licence
+ * as published by the Free Software Foundation; either version
+ * 2 of the Licence, or (at your option) any later version.
+ */
+#include <linux/mm.h>
+
+/*
+ * allow userspace to flush the instruction cache
+ */
+asmlinkage long sys_cacheflush(unsigned long start, unsigned long end)
+{
+	if (end < start)
+		return -EINVAL;
+	return 0;
+}


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-09-29  0:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-29  0:57 [PATCH] MN10300: Handle missing sys_cacheflush() when caching disabled [ver #2] David Howells

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®