From: Borislav Petkov <bp@alien8.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86, cpu: X86_FEATURE_NOPL should be disabled on 32-bit only
Date: Sun, 3 Oct 2010 22:11:39 +0200 [thread overview]
Message-ID: <20101003201139.GA16532@liondog.tnic> (raw)
In-Reply-To: <a3fce0e5-e6c5-4bf0-b8c0-4954825a7065@email.android.com>
From: "H. Peter Anvin" <hpa@zytor.com>
Date: Sun, Oct 03, 2010 at 11:19:18AM -0700
> I think we actually need to set it on 64 bits.
Ok, correct me if I'm wrong but I think it is already "indirectly" set
on 64-bits through REQUIRED_MASK3:
#define REQUIRED_MASK3 (NEED_NOPL)
which is defined as
#define NEED_NOPL (1<<(X86_FEATURE_NOPL & 31))
when either CONFIG_X86_P6_NOP or CONFIG_X86_64 are selected.
and cpu_has() does
#define cpu_has(c, bit) \
(__builtin_constant_p(bit) && \
...
(((bit)>>5)==3 && (1UL<<((bit)&31) & REQUIRED_MASK3)) || \
...
? 1 : test_cpu_cap(c, bit))
which returns 1 when testing for X86_FEATURE_NOPL, no?
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2010-10-03 20:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-03 9:37 NOPL on 32-bit Borislav Petkov
2010-10-03 14:43 ` H. Peter Anvin
2010-10-03 15:22 ` [PATCH] x86, cpu: X86_FEATURE_NOPL should be disabled on 32-bit only Borislav Petkov
2010-10-03 18:19 ` H. Peter Anvin
2010-10-03 20:11 ` Borislav Petkov [this message]
2010-10-03 22:22 ` H. Peter Anvin
2010-10-04 7:31 ` [PATCH] x86, cpu: Fix X86_FEATURE_NOPL Borislav Petkov
2010-10-04 20:36 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-10-05 9:47 ` Borislav Petkov
2010-10-05 16:30 ` H. Peter Anvin
2010-10-05 16:53 ` Borislav Petkov
2010-10-04 20:47 ` [PATCH] " Linus Torvalds
2010-10-04 21:02 ` H. Peter Anvin
2010-10-04 21:12 ` Linus Torvalds
2010-10-04 21:21 ` H. Peter Anvin
2010-10-04 21:48 ` Borislav Petkov
2010-10-04 21:50 ` H. Peter Anvin
2010-10-04 21:53 ` H. Peter Anvin
2010-10-05 6:19 ` Borislav Petkov
2010-10-04 22:17 ` Hugh Dickins
2010-10-04 22:19 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101003201139.GA16532@liondog.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®