mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86, cpu: X86_FEATURE_NOPL should be disabled on 32-bit only
Date: Sun, 03 Oct 2010 11:19:18 -0700	[thread overview]
Message-ID: <a3fce0e5-e6c5-4bf0-b8c0-4954825a7065@email.android.com> (raw)
In-Reply-To: <20101003152212.GA13233@liondog.tnic>

I think we actually need to set it on 64 bits.

"Borislav Petkov" <bp@alien8.de> wrote:

>ba0593bf553c450a03dbc5f8c1f0ff58b778a0c8 cleared the aforementioned
>cpuid bit only on 32-bit due to various problems with Virtual PC. This
>somehow got lost during the 32- + 64-bit merge so restore the feature
>bit on 64-bit.
>
>Signed-off-by: Borislav Petkov <bp@alien8.de>
>---
> arch/x86/kernel/cpu/common.c |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
>index caa967d..9a2cfeb 100644
>--- a/arch/x86/kernel/cpu/common.c
>+++ b/arch/x86/kernel/cpu/common.c
>@@ -713,7 +713,9 @@ void __init early_cpu_init(void)
>  */
> static void __cpuinit detect_nopl(struct cpuinfo_x86 *c)
> {
>+#ifdef CONFIG_X86_32
> 	clear_cpu_cap(c, X86_FEATURE_NOPL);
>+#endif
> }
> 
> static void __cpuinit generic_identify(struct cpuinfo_x86 *c)
>-- 
>1.7.2.3
>
>-- 
>Regards/Gruss,
>    Boris.

-- 
Sent from my mobile phone.  Please pardon any lack of formatting.

  reply	other threads:[~2010-10-03 18:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-03  9:37 NOPL on 32-bit Borislav Petkov
2010-10-03 14:43 ` H. Peter Anvin
2010-10-03 15:22   ` [PATCH] x86, cpu: X86_FEATURE_NOPL should be disabled on 32-bit only Borislav Petkov
2010-10-03 18:19     ` H. Peter Anvin [this message]
2010-10-03 20:11       ` Borislav Petkov
2010-10-03 22:22         ` H. Peter Anvin
2010-10-04  7:31           ` [PATCH] x86, cpu: Fix X86_FEATURE_NOPL Borislav Petkov
2010-10-04 20:36             ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-10-05  9:47               ` Borislav Petkov
2010-10-05 16:30                 ` H. Peter Anvin
2010-10-05 16:53                   ` Borislav Petkov
2010-10-04 20:47             ` [PATCH] " Linus Torvalds
2010-10-04 21:02               ` H. Peter Anvin
2010-10-04 21:12                 ` Linus Torvalds
2010-10-04 21:21                   ` H. Peter Anvin
2010-10-04 21:48                     ` Borislav Petkov
2010-10-04 21:50                       ` H. Peter Anvin
2010-10-04 21:53                       ` H. Peter Anvin
2010-10-05  6:19                         ` Borislav Petkov
2010-10-04 22:17                     ` Hugh Dickins
2010-10-04 22:19                       ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3fce0e5-e6c5-4bf0-b8c0-4954825a7065@email.android.com \
    --to=hpa@zytor.com \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®