* [PATCH] pid: remove unused include
@ 2010-10-05 11:20 jovi zhang
2010-10-05 17:19 ` Alexey Dobriyan
0 siblings, 1 reply; 4+ messages in thread
From: jovi zhang @ 2010-10-05 11:20 UTC (permalink / raw)
To: andre.goddard, hedi; +Cc: linux-kernel
remove unused include of pid.c
Signed-off-by: jovi zhang <bookjovi@gmail.com>
kernel/pid.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/kernel/pid.c b/kernel/pid.c
index d55c6fb..6de4c07 100644
--- a/kernel/pid.c
+++ b/kernel/pid.c
@@ -27,15 +27,12 @@
*/
#include <linux/mm.h>
-#include <linux/module.h>
-#include <linux/slab.h>
#include <linux/init.h>
#include <linux/rculist.h>
#include <linux/bootmem.h>
#include <linux/hash.h>
#include <linux/pid_namespace.h>
#include <linux/init_task.h>
-#include <linux/syscalls.h>
#define pid_hashfn(nr, ns) \
hash_long((unsigned long)nr + (unsigned long)ns, pidhash_shift)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pid: remove unused include
2010-10-05 11:20 [PATCH] pid: remove unused include jovi zhang
@ 2010-10-05 17:19 ` Alexey Dobriyan
2010-10-06 3:43 ` jovi zhang
0 siblings, 1 reply; 4+ messages in thread
From: Alexey Dobriyan @ 2010-10-05 17:19 UTC (permalink / raw)
To: jovi zhang; +Cc: andre.goddard, hedi, linux-kernel
On Tue, Oct 05, 2010 at 07:20:26PM +0800, jovi zhang wrote:
> remove unused include of pid.c
> --- a/kernel/pid.c
> +++ b/kernel/pid.c
> @@ -27,15 +27,12 @@
> */
>
> #include <linux/mm.h>
> -#include <linux/module.h>
This one is needed for EXPORT_SYMBOL_GPL.
> -#include <linux/slab.h>
This one is for kzalloc()
> #include <linux/init.h>
> #include <linux/rculist.h>
> #include <linux/bootmem.h>
> #include <linux/hash.h>
> #include <linux/pid_namespace.h>
> #include <linux/init_task.h>
> -#include <linux/syscalls.h>
This one can go, sys_wait4() usage was removed.
Have you checked compilation?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pid: remove unused include
2010-10-05 17:19 ` Alexey Dobriyan
@ 2010-10-06 3:43 ` jovi zhang
0 siblings, 0 replies; 4+ messages in thread
From: jovi zhang @ 2010-10-06 3:43 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: andre.goddard, hedi, linux-kernel
On Wed, Oct 6, 2010 at 1:19 AM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On Tue, Oct 05, 2010 at 07:20:26PM +0800, jovi zhang wrote:
>> remove unused include of pid.c
>
>> --- a/kernel/pid.c
>> +++ b/kernel/pid.c
>> @@ -27,15 +27,12 @@
>> */
>>
>> #include <linux/mm.h>
>> -#include <linux/module.h>
>
> This one is needed for EXPORT_SYMBOL_GPL.
>
>> -#include <linux/slab.h>
>
>
> This one is for kzalloc()
>
>> #include <linux/init.h>
>> #include <linux/rculist.h>
>> #include <linux/bootmem.h>
>> #include <linux/hash.h>
>> #include <linux/pid_namespace.h>
>> #include <linux/init_task.h>
>> -#include <linux/syscalls.h>
>
> This one can go, sys_wait4() usage was removed.
> Have you checked compilation?
>
Sorry, It's my fault, I just compile kernel/pid.o.
I'm kicking myself for did this.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] pid: remove unused include
@ 2010-10-26 8:44 jovi zhang
0 siblings, 0 replies; 4+ messages in thread
From: jovi zhang @ 2010-10-26 8:44 UTC (permalink / raw)
To: akpm, andre.goddard, josh; +Cc: linux-kernel
Sorry, I forget re-send the new patch.
remove unused include
Signed-off-by: bookjovi@gmail.com
kernel/pid.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/kernel/pid.c b/kernel/pid.c
index 39b65b6..5e8e8c6 100644
--- a/kernel/pid.c
+++ b/kernel/pid.c
@@ -35,7 +35,6 @@
#include <linux/hash.h>
#include <linux/pid_namespace.h>
#include <linux/init_task.h>
-#include <linux/syscalls.h>
#define pid_hashfn(nr, ns) \
hash_long((unsigned long)nr + (unsigned long)ns, pidhash_shift)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-26 8:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-05 11:20 [PATCH] pid: remove unused include jovi zhang
2010-10-05 17:19 ` Alexey Dobriyan
2010-10-06 3:43 ` jovi zhang
2010-10-26 8:44 jovi zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®