* [2.6.36 REGRESSION] Re: virtio-blk: put request that was created to retrieve the device id
[not found] ` <20100921210033.GA24729@infradead.org>
@ 2010-10-08 16:06 ` Mike Snitzer
0 siblings, 0 replies; only message in thread
From: Mike Snitzer @ 2010-10-08 16:06 UTC (permalink / raw)
To: rusty
Cc: Christoph Hellwig, Ryan Harper, Tejun Heo, Mikulas Patocka,
dm-devel, Vivek Goyal, john.cooper, kvm, linux-kernel
Hi Rusty,
On Tue, Sep 21 2010 at 5:00pm -0400,
Christoph Hellwig <hch@infradead.org> wrote:
> On Fri, Sep 17, 2010 at 09:58:48AM -0500, Ryan Harper wrote:
> > Since __bio_map_kern() sets up bio->bi_end_io = bio_map_kern_endio
> > (which does a bio_put(bio)) doesn't that ensure we don't leak?
>
> Indeed, that should take care of it.
>
We need to fix this regression for 2.6.36. Not sure what else I need to
do to get this on your radar. It's a pretty significant show-stopper
for 2.6.36 guests that use virtio-blk with a udev enabled distro.
Here is a reference to my original patch (which Ryan and hch have both
reviewed): https://patchwork.kernel.org/patch/165571/
Thanks,
Mike
^ permalink raw reply [flat|nested] only message in thread