mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	linux-main <linux-kernel@vger.kernel.org>,
	Greg KH <greg@kroah.com>, "Balbi, Felipe" <balbi@ti.com>
Subject: Re: [PATCH 1/3] usb: fix Kconfig warning
Date: Tue, 19 Oct 2010 11:20:13 +0300	[thread overview]
Message-ID: <20101019082013.GJ12470@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1287475466-8927-2-git-send-email-felipe.contreras@gmail.com>

On Tue, Oct 19, 2010 at 03:04:24AM -0500, Felipe Contreras wrote:
>warning: (USB_MUSB_HDRC_HCD && USB_SUPPORT && USB_MUSB_HDRC &&
>(USB_MUSB_HOST || USB_MUSB_OTG) && USB_GADGET_MUSB_HDRC || USB_MUSB_OTG
>&& <choice> && USB && USB_GADGET && PM && EXPERIMENTAL) selects USB_OTG
>which has unmet direct dependencies (USB_GADGET_OMAP && ARCH_OMAP_OTG &&
>USB_OHCI_HCD)
>
>This doesn't seem to happen on 2.6.36-rc8, but still doesn't make sense
>to keep this useless config.
>
>Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>---
> drivers/usb/gadget/Kconfig |   11 -----------
> 1 files changed, 0 insertions(+), 11 deletions(-)
>
>diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
>index cd27f9b..19a6eb6 100644
>--- a/drivers/usb/gadget/Kconfig
>+++ b/drivers/usb/gadget/Kconfig
>@@ -209,17 +209,6 @@ config USB_OMAP
> 	default USB_GADGET
> 	select USB_GADGET_SELECTED
>
>-config USB_OTG
>-	boolean "OTG Support"
>-	depends on USB_GADGET_OMAP && ARCH_OMAP_OTG && USB_OHCI_HCD
>-	help
>-	   The most notable feature of USB OTG is support for a
>-	   "Dual-Role" device, which can act as either a device
>-	   or a host.  The initial role choice can be changed
>-	   later, when two dual-role devices talk to each other.
>-
>-	   Select this only if your OMAP board has a Mini-AB connector.
>-

ok since this is replicated on drivers/usb/core/Kconfig but it's not
reflected on changelog. Could you add some extra comment ?

-- 
balbi

  reply	other threads:[~2010-10-19  8:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19  8:04 [PATCH 0/3] usb: geneirc Kconfig fixes Felipe Contreras
2010-10-19  8:04 ` [PATCH 1/3] usb: fix Kconfig warning Felipe Contreras
2010-10-19  8:20   ` Felipe Balbi [this message]
2010-10-19  8:04 ` [PATCH 2/3] usb: trivial Kconfig cleanups Felipe Contreras
2010-10-19  8:15   ` Felipe Balbi
2010-10-19  8:25     ` Felipe Contreras
2010-10-19  8:29       ` Felipe Balbi
2010-10-19  8:04 ` [PATCH 3/3] drivers: cleanup Kconfig stuff Felipe Contreras
2010-10-19  8:18   ` Felipe Balbi
2010-10-19  8:34     ` Felipe Contreras
2010-10-19  9:01       ` Felipe Balbi
2010-10-19  9:55         ` Felipe Contreras
2010-10-19 10:12           ` Felipe Balbi
2010-10-19 10:52             ` Felipe Contreras
2010-10-19 11:28               ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101019082013.GJ12470@legolas.emea.dhcp.ti.com \
    --to=balbi@ti.com \
    --cc=felipe.contreras@gmail.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®