From: Felipe Balbi <balbi@ti.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "Balbi, Felipe" <balbi@ti.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
linux-main <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>
Subject: Re: [PATCH 3/3] drivers: cleanup Kconfig stuff
Date: Tue, 19 Oct 2010 12:01:49 +0300 [thread overview]
Message-ID: <20101019090149.GC31170@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <AANLkTi=8=M+egdo5o6nyMOaCyMCLaZdwJF3WKFwZnbd4@mail.gmail.com>
Hi,
On Tue, Oct 19, 2010 at 03:34:55AM -0500, Felipe Contreras wrote:
>> It was fine as it was before. NAK
>
>It's not fine. You can build with CONFIG_USB_G_NOKIA=y, and it doesn't
>work. Definitely some dependency is missing.
if phonet is not set it should not build. If phonet is set to module and
g_nokia to built-in, then it's your mistake.
>How do you handle USB_MUSB_HDRC=y and NOP_USB_XCEIV=n and TWL4030_USB=n?
>
>depends on (NOP_USB_XCEIV || TWL4030_USB) ?
you're selecting, not depending on this patch. What I mean is that you
will enable a useless driver on some boards if you "select TWL4030_USB
if ARCH_OMAP3"
--
balbi
next prev parent reply other threads:[~2010-10-19 9:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 8:04 [PATCH 0/3] usb: geneirc Kconfig fixes Felipe Contreras
2010-10-19 8:04 ` [PATCH 1/3] usb: fix Kconfig warning Felipe Contreras
2010-10-19 8:20 ` Felipe Balbi
2010-10-19 8:04 ` [PATCH 2/3] usb: trivial Kconfig cleanups Felipe Contreras
2010-10-19 8:15 ` Felipe Balbi
2010-10-19 8:25 ` Felipe Contreras
2010-10-19 8:29 ` Felipe Balbi
2010-10-19 8:04 ` [PATCH 3/3] drivers: cleanup Kconfig stuff Felipe Contreras
2010-10-19 8:18 ` Felipe Balbi
2010-10-19 8:34 ` Felipe Contreras
2010-10-19 9:01 ` Felipe Balbi [this message]
2010-10-19 9:55 ` Felipe Contreras
2010-10-19 10:12 ` Felipe Balbi
2010-10-19 10:52 ` Felipe Contreras
2010-10-19 11:28 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019090149.GC31170@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=felipe.contreras@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®