From: "Michał Mirosław" <mirq@rere.qmqm.pl>
To: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: Shaohua Li <shaohua.li@intel.com>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] percpu: Introduce a read-mostly percpu API
Date: Sat, 23 Oct 2010 04:25:45 +0200 [thread overview]
Message-ID: <20101023022545.GA18876@rere.qmqm.pl> (raw)
Commit c957ef2c59e952803766ddc22e89981ab534606f that just went into
Linus' tree has a bug - only one of hunks was modified (.readmostly
moved after .page_aligned).
>commit c957ef2c59e952803766ddc22e89981ab534606f
>Author: Shaohua Li <shaohua.li@intel.com>
>Date: Wed Oct 20 11:07:02 2010 +0800
>
> percpu: Introduce a read-mostly percpu API
>
> Add a new readmostly percpu section and API. This can be used to
> avoid dirtying data lines which are generally not written to, which is
> especially important for data which may be accessed by processors
> other than the one for which the percpu area belongs to.
>
> [ hpa: moved it *after* the page-aligned section, for obvious
> reasons. ]
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
> LKML-Reference: <1287544022.4571.7.camel@sli10-conroe.sh.intel.com>
> Cc: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
>
>diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
>index 8a92a17..d7e7b21 100644
>--- a/include/asm-generic/vmlinux.lds.h
>+++ b/include/asm-generic/vmlinux.lds.h
>@@ -677,7 +677,9 @@
> - LOAD_OFFSET) { \
> VMLINUX_SYMBOL(__per_cpu_start) = .; \
> *(.data..percpu..first) \
>+ . = ALIGN(PAGE_SIZE); \
> *(.data..percpu..page_aligned) \
>+ *(.data..percpu..readmostly) \
> *(.data..percpu) \
> *(.data..percpu..shared_aligned) \
> VMLINUX_SYMBOL(__per_cpu_end) = .; \
>@@ -703,6 +705,8 @@
> VMLINUX_SYMBOL(__per_cpu_load) = .; \
> VMLINUX_SYMBOL(__per_cpu_start) = .; \
> *(.data..percpu..first) \
>+ . = ALIGN(PAGE_SIZE); \
>+ *(.data..percpu..readmostly) \
> *(.data..percpu..page_aligned) \
Here.
> *(.data..percpu) \
> *(.data..percpu..shared_aligned) \
[...]
Best Regards,
Michał Mirosław
next reply other threads:[~2010-10-23 2:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-23 2:25 Michał Mirosław [this message]
2010-10-23 2:30 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101023022545.GA18876@rere.qmqm.pl \
--to=mirq@rere.qmqm.pl \
--cc=hpa@linux.intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®