* Re: [PATCH] percpu: Introduce a read-mostly percpu API
@ 2010-10-23 2:25 Michał Mirosław
2010-10-23 2:30 ` Michał Mirosław
0 siblings, 1 reply; 2+ messages in thread
From: Michał Mirosław @ 2010-10-23 2:25 UTC (permalink / raw)
To: H. Peter Anvin; +Cc: Shaohua Li, linux-arch, linux-kernel
Commit c957ef2c59e952803766ddc22e89981ab534606f that just went into
Linus' tree has a bug - only one of hunks was modified (.readmostly
moved after .page_aligned).
>commit c957ef2c59e952803766ddc22e89981ab534606f
>Author: Shaohua Li <shaohua.li@intel.com>
>Date: Wed Oct 20 11:07:02 2010 +0800
>
> percpu: Introduce a read-mostly percpu API
>
> Add a new readmostly percpu section and API. This can be used to
> avoid dirtying data lines which are generally not written to, which is
> especially important for data which may be accessed by processors
> other than the one for which the percpu area belongs to.
>
> [ hpa: moved it *after* the page-aligned section, for obvious
> reasons. ]
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
> LKML-Reference: <1287544022.4571.7.camel@sli10-conroe.sh.intel.com>
> Cc: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
>
>diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
>index 8a92a17..d7e7b21 100644
>--- a/include/asm-generic/vmlinux.lds.h
>+++ b/include/asm-generic/vmlinux.lds.h
>@@ -677,7 +677,9 @@
> - LOAD_OFFSET) { \
> VMLINUX_SYMBOL(__per_cpu_start) = .; \
> *(.data..percpu..first) \
>+ . = ALIGN(PAGE_SIZE); \
> *(.data..percpu..page_aligned) \
>+ *(.data..percpu..readmostly) \
> *(.data..percpu) \
> *(.data..percpu..shared_aligned) \
> VMLINUX_SYMBOL(__per_cpu_end) = .; \
>@@ -703,6 +705,8 @@
> VMLINUX_SYMBOL(__per_cpu_load) = .; \
> VMLINUX_SYMBOL(__per_cpu_start) = .; \
> *(.data..percpu..first) \
>+ . = ALIGN(PAGE_SIZE); \
>+ *(.data..percpu..readmostly) \
> *(.data..percpu..page_aligned) \
Here.
> *(.data..percpu) \
> *(.data..percpu..shared_aligned) \
[...]
Best Regards,
Michał Mirosław
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] percpu: Introduce a read-mostly percpu API
2010-10-23 2:25 [PATCH] percpu: Introduce a read-mostly percpu API Michał Mirosław
@ 2010-10-23 2:30 ` Michał Mirosław
0 siblings, 0 replies; 2+ messages in thread
From: Michał Mirosław @ 2010-10-23 2:30 UTC (permalink / raw)
To: H. Peter Anvin; +Cc: Shaohua Li, linux-arch, linux-kernel
On Sat, Oct 23, 2010 at 04:25:45AM +0200, Michał Mirosław wrote:
> Commit c957ef2c59e952803766ddc22e89981ab534606f that just went into
> Linus' tree has a bug - only one of hunks was modified (.readmostly
> moved after .page_aligned).
Ah. I just found another commit that fixes it. Sorry for the noise.
Best Regards,
Michał Mirosław
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-23 2:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-23 2:25 [PATCH] percpu: Introduce a read-mostly percpu API Michał Mirosław
2010-10-23 2:30 ` Michał Mirosław
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®