From: Jonathan Corbet <corbet@lwn.net>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] VIA Chrome integrated camera controller driver includes headers multiple times
Date: Sat, 30 Oct 2010 08:48:13 -0600 [thread overview]
Message-ID: <20101030084813.3581ea7e@bike.lwn.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1010301527580.7979@swampdragon.chaosbits.net>
On Sat, 30 Oct 2010 15:32:32 +0200 (CEST)
Jesper Juhl <jj@chaosbits.net> wrote:
> The VIA Chrome integrated camera controller driver includes both
> 'linux/pci.h' and 'linux/device.h' twice. This gets rid of the duplicates.
Well, you see...I have teenage children. So I've gotten very much used
to the idea that you have to ask for anything at *least* twice have any
chance of it actually happening. Beyond that, the VIA controller has
certain adolescent behavior patterns of its own...watch out when it's
in a bad mood...so I just kind of fell into the habit of insisting.
Even then, I've been known to check with gcc -E to be *sure* it got
included.
Seriously, though, I'm not sure how that happened. Obviously:
Acked-by: Jonathan Corbet <corbet@lwn.net>
Thanks,
jon
next prev parent reply other threads:[~2010-10-30 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-30 13:32 Jesper Juhl
2010-10-30 14:48 ` Jonathan Corbet [this message]
2010-10-30 20:21 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101030084813.3581ea7e@bike.lwn.net \
--to=corbet@lwn.net \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®