[PATCH] VIA Chrome integrated camera controller driver includes headers multiple times

[PATCH] VIA Chrome integrated camera controller driver includes headers multiple times

[Jesper Juhl]

Hi,

The VIA Chrome integrated camera controller driver includes both 
'linux/pci.h' and 'linux/device.h' twice. This gets rid of the duplicates.


Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
 via-camera.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/media/video/via-camera.c b/drivers/media/video/via-camera.c
index 02a21bc..6f52818 100644
--- a/drivers/media/video/via-camera.c
+++ b/drivers/media/video/via-camera.c
@@ -13,14 +13,12 @@
 #include <linux/pci.h>
 #include <linux/gpio.h>
 #include <linux/interrupt.h>
-#include <linux/pci.h>
 #include <linux/platform_device.h>
 #include <linux/videodev2.h>
 #include <media/v4l2-device.h>
 #include <media/v4l2-ioctl.h>
 #include <media/v4l2-chip-ident.h>
 #include <media/videobuf-dma-sg.h>
-#include <linux/device.h>
 #include <linux/delay.h>
 #include <linux/dma-mapping.h>
 #include <linux/pm_qos_params.h>


-- 
Jesper Juhl <jj@chaosbits.net>             http://www.chaosbits.net/
Plain text mails only, please      http://www.expita.com/nomime.html
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html

Re: [PATCH] VIA Chrome integrated camera controller driver includes headers multiple times

[Jonathan Corbet]

On Sat, 30 Oct 2010 15:32:32 +0200 (CEST)
Jesper Juhl <jj@chaosbits.net> wrote:

> The VIA Chrome integrated camera controller driver includes both 
> 'linux/pci.h' and 'linux/device.h' twice. This gets rid of the duplicates.

Well, you see...I have teenage children.  So I've gotten very much used
to the idea that you have to ask for anything at *least* twice have any
chance of it actually happening.  Beyond that, the VIA controller has
certain adolescent behavior patterns of its own...watch out when it's
in a bad mood...so I just kind of fell into the habit of insisting.
Even then, I've been known to check with gcc -E to be *sure* it got
included.

Seriously, though, I'm not sure how that happened.   Obviously:

	Acked-by: Jonathan Corbet <corbet@lwn.net>

Thanks,

jon

Re: [PATCH] VIA Chrome integrated camera controller driver includes headers multiple times

[Jiri Kosina]

On Sat, 30 Oct 2010, Jonathan Corbet wrote:

> > The VIA Chrome integrated camera controller driver includes both 
> > 'linux/pci.h' and 'linux/device.h' twice. This gets rid of the duplicates.
> 
> Well, you see...I have teenage children.  So I've gotten very much used
> to the idea that you have to ask for anything at *least* twice have any
> chance of it actually happening.  Beyond that, the VIA controller has
> certain adolescent behavior patterns of its own...watch out when it's
> in a bad mood...so I just kind of fell into the habit of insisting.

It's always good to know the background of the bug. Do you want this to be 
included in the changelog? :)

> Seriously, though, I'm not sure how that happened.   Obviously:
> 
> 	Acked-by: Jonathan Corbet <corbet@lwn.net>

Applied. Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.