* drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized @ 2010-10-31 17:51 Stefan Richter 2010-10-31 22:18 ` Dmitry Torokhov 0 siblings, 1 reply; 5+ messages in thread From: Stefan Richter @ 2010-10-31 17:51 UTC (permalink / raw) To: Dmitry Torokhov; +Cc: linux-media, linux-kernel Commit 9f470095068e "Input: media/IR - switch to using new keycode interface" added the following build warning: drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode': drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used uninitialized in this function It is due to an actual bug but I don't know the fix. -- Stefan Richter -=====-==-=- =-=- ===== http://arcgraph.de/sr/ ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized 2010-10-31 17:51 drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized Stefan Richter @ 2010-10-31 22:18 ` Dmitry Torokhov 2010-11-02 16:04 ` Jarod Wilson 0 siblings, 1 reply; 5+ messages in thread From: Dmitry Torokhov @ 2010-10-31 22:18 UTC (permalink / raw) To: Stefan Richter, Linus Torvalds; +Cc: linux-media, linux-kernel, mchehab On Sunday, October 31, 2010 10:51:21 am Stefan Richter wrote: > Commit 9f470095068e "Input: media/IR - switch to using new keycode > interface" added the following build warning: > > drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode': > drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used uninitialized in this function > > It is due to an actual bug but I don't know the fix. > The patch below should fix it. I wonder if Linus released -rc1 yet... -- Dmitry Input: ir-keytable - fix uninitialized variable warning From: Dmitry Torokhov <dmitry.torokhov@gmail.com> We were forgetting to set up proper return value in success path causing ir_getkeycode() to fail intermittently: drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode': drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used uninitialized in this function Reported-by: Stefan Richter <stefanr@s5r6.in-berlin.de> Signed-off-by: Dmitry Torokhov <dtor@mail.ru> --- drivers/media/IR/ir-keytable.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir-keytable.c index 9186b45..f7fafff 100644 --- a/drivers/media/IR/ir-keytable.c +++ b/drivers/media/IR/ir-keytable.c @@ -389,6 +389,8 @@ static int ir_getkeycode(struct input_dev *dev, ke->len = sizeof(entry->scancode); memcpy(ke->scancode, &entry->scancode, sizeof(entry->scancode)); + retval = 0; + out: spin_unlock_irqrestore(&rc_tab->lock, flags); return retval; ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized 2010-10-31 22:18 ` Dmitry Torokhov @ 2010-11-02 16:04 ` Jarod Wilson 2010-11-02 16:24 ` Dmitry Torokhov 0 siblings, 1 reply; 5+ messages in thread From: Jarod Wilson @ 2010-11-02 16:04 UTC (permalink / raw) To: Dmitry Torokhov Cc: Stefan Richter, Linus Torvalds, linux-media, linux-kernel, mchehab On Sun, Oct 31, 2010 at 6:18 PM, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > On Sunday, October 31, 2010 10:51:21 am Stefan Richter wrote: >> Commit 9f470095068e "Input: media/IR - switch to using new keycode >> interface" added the following build warning: >> >> drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode': >> drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used uninitialized in this function >> >> It is due to an actual bug but I don't know the fix. >> > > The patch below should fix it. I wonder if Linus released -rc1 yet... Looks like it missed rc1. > Input: ir-keytable - fix uninitialized variable warning > > From: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > We were forgetting to set up proper return value in success path causing > ir_getkeycode() to fail intermittently: > > drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode': > drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used > uninitialized in this function > > Reported-by: Stefan Richter <stefanr@s5r6.in-berlin.de> > Signed-off-by: Dmitry Torokhov <dtor@mail.ru> Acked-by: Jarod Wilson <jarod@redhat.com> -- Jarod Wilson jarod@wilsonet.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized 2010-11-02 16:04 ` Jarod Wilson @ 2010-11-02 16:24 ` Dmitry Torokhov 2010-11-02 20:21 ` Jarod Wilson 0 siblings, 1 reply; 5+ messages in thread From: Dmitry Torokhov @ 2010-11-02 16:24 UTC (permalink / raw) To: Jarod Wilson Cc: Stefan Richter, Linus Torvalds, linux-media, linux-kernel, mchehab On Tue, Nov 02, 2010 at 12:04:56PM -0400, Jarod Wilson wrote: > On Sun, Oct 31, 2010 at 6:18 PM, Dmitry Torokhov > <dmitry.torokhov@gmail.com> wrote: > > On Sunday, October 31, 2010 10:51:21 am Stefan Richter wrote: > >> Commit 9f470095068e "Input: media/IR - switch to using new keycode > >> interface" added the following build warning: > >> > >> drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode': > >> drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used uninitialized in this function > >> > >> It is due to an actual bug but I don't know the fix. > >> > > > > The patch below should fix it. I wonder if Linus released -rc1 yet... > > Looks like it missed rc1. > Nope, I see it there, 47c5ba53bc5e5f88b5d1bbb97acd25afc27f74eb ;) -- Dmitry ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized 2010-11-02 16:24 ` Dmitry Torokhov @ 2010-11-02 20:21 ` Jarod Wilson 0 siblings, 0 replies; 5+ messages in thread From: Jarod Wilson @ 2010-11-02 20:21 UTC (permalink / raw) To: Dmitry Torokhov Cc: Stefan Richter, Linus Torvalds, linux-media, linux-kernel, mchehab On Tue, Nov 2, 2010 at 12:24 PM, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > On Tue, Nov 02, 2010 at 12:04:56PM -0400, Jarod Wilson wrote: >> On Sun, Oct 31, 2010 at 6:18 PM, Dmitry Torokhov >> <dmitry.torokhov@gmail.com> wrote: >> > On Sunday, October 31, 2010 10:51:21 am Stefan Richter wrote: >> >> Commit 9f470095068e "Input: media/IR - switch to using new keycode >> >> interface" added the following build warning: >> >> >> >> drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode': >> >> drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used uninitialized in this function >> >> >> >> It is due to an actual bug but I don't know the fix. >> >> >> > >> > The patch below should fix it. I wonder if Linus released -rc1 yet... >> >> Looks like it missed rc1. >> > > Nope, I see it there, 47c5ba53bc5e5f88b5d1bbb97acd25afc27f74eb ;) Oh, damn. Sorry for the noise... I blame it on my cold... :) -- Jarod Wilson jarod@wilsonet.com ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-11-02 20:21 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2010-10-31 17:51 drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized Stefan Richter 2010-10-31 22:18 ` Dmitry Torokhov 2010-11-02 16:04 ` Jarod Wilson 2010-11-02 16:24 ` Dmitry Torokhov 2010-11-02 20:21 ` Jarod Wilson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
Powered by JetHome