From: Pavel Machek <pavel@ucw.cz>
To: Pekka Enberg <penberg@kernel.org>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] w35und: Kill empty Mds_Destroy function
Date: Mon, 1 Nov 2010 22:15:49 +0100 [thread overview]
Message-ID: <20101101211549.GE22934@elf.ucw.cz> (raw)
In-Reply-To: <1288643371-10310-1-git-send-email-penberg@kernel.org>
On Mon 2010-11-01 22:29:28, Pekka Enberg wrote:
> The Mds_Destroy() function doesn't do anything so kill it.
>
> Cc: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Pekka Enberg <penberg@kernel.org>
ACK.
> ---
> drivers/staging/winbond/mds.c | 5 -----
> drivers/staging/winbond/mds_f.h | 1 -
> drivers/staging/winbond/wbusb.c | 2 --
> 3 files changed, 0 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/winbond/mds.c b/drivers/staging/winbond/mds.c
> index 9ac2c87..90f2cc0 100644
> --- a/drivers/staging/winbond/mds.c
> +++ b/drivers/staging/winbond/mds.c
> @@ -18,11 +18,6 @@ Mds_initial(struct wbsoft_priv *adapter)
> return hal_get_tx_buffer(&adapter->sHwData, &pMds->pTxBuffer);
> }
>
> -void
> -Mds_Destroy(struct wbsoft_priv *adapter)
> -{
> -}
> -
> static void Mds_DurationSet(struct wbsoft_priv *adapter, struct wb35_descriptor *pDes, u8 *buffer)
> {
> struct T00_descriptor *pT00;
> diff --git a/drivers/staging/winbond/mds_f.h b/drivers/staging/winbond/mds_f.h
> index d902843..ce8be07 100644
> --- a/drivers/staging/winbond/mds_f.h
> +++ b/drivers/staging/winbond/mds_f.h
> @@ -5,7 +5,6 @@
> #include "core.h"
>
> unsigned char Mds_initial(struct wbsoft_priv *adapter);
> -void Mds_Destroy(struct wbsoft_priv *adapter);
> void Mds_Tx(struct wbsoft_priv *adapter);
> void Mds_SendComplete(struct wbsoft_priv *adapter, struct T02_descriptor *pt02);
> void Mds_MpduProcess(struct wbsoft_priv *adapter, struct wb35_descriptor *prxdes);
> diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c
> index df055ab..82040f4 100644
> --- a/drivers/staging/winbond/wbusb.c
> +++ b/drivers/staging/winbond/wbusb.c
> @@ -863,8 +863,6 @@ static void hal_halt(struct hw_data *pHwData)
>
> static void wb35_hw_halt(struct wbsoft_priv *adapter)
> {
> - Mds_Destroy(adapter);
> -
> /* Turn off Rx and Tx hardware ability */
> hal_stop(&adapter->sHwData);
> #ifdef _PE_USB_INI_DUMP_
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2010-11-01 21:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 20:29 Pekka Enberg
2010-11-01 20:29 ` [PATCH 2/4] w35und: Kill struct hwdata ->NullPacketCount Pekka Enberg
2010-11-01 21:16 ` Pavel Machek
2010-11-01 20:29 ` [PATCH 3/4] w35und: Kill struct hwdata ->HwStop Pekka Enberg
2010-11-01 20:29 ` [PATCH 4/4] w35und: Kill struct hwdata ->SurpriseRemoveCount Pekka Enberg
2010-11-01 21:15 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101101211549.GE22934@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome