* [PATCH Resend] dma: imx-dma: fix imxdma_probe error path
@ 2010-11-02 1:56 Axel Lin
2010-11-02 7:40 ` Pengutronix
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2010-11-02 1:56 UTC (permalink / raw)
To: linux-kernel; +Cc: Pengutronix, Dan Williams, Thiago Farina
Otherwise, the i variable will be -1 inside the latest iteration of the while loop.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
This resend only update the commit log.
Regards,
Axel
drivers/dma/imx-dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
index f629e49..e53d438 100644
--- a/drivers/dma/imx-dma.c
+++ b/drivers/dma/imx-dma.c
@@ -379,7 +379,7 @@ static int __init imxdma_probe(struct platform_device *pdev)
return 0;
err_init:
- while (i-- >= 0) {
+ while (--i >= 0) {
struct imxdma_channel *imxdmac = &imxdma->channel[i];
imx_dma_free(imxdmac->imxdma_channel);
}
--
1.7.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH Resend] dma: imx-dma: fix imxdma_probe error path
2010-11-02 1:56 [PATCH Resend] dma: imx-dma: fix imxdma_probe error path Axel Lin
@ 2010-11-02 7:40 ` Pengutronix
0 siblings, 0 replies; 2+ messages in thread
From: Pengutronix @ 2010-11-02 7:40 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Dan Williams, Thiago Farina
On Tue, Nov 02, 2010 at 09:56:11AM +0800, Axel Lin wrote:
> Otherwise, the i variable will be -1 inside the latest iteration of the while loop.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> This resend only update the commit log.
> Regards,
> Axel
>
> drivers/dma/imx-dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
> index f629e49..e53d438 100644
> --- a/drivers/dma/imx-dma.c
> +++ b/drivers/dma/imx-dma.c
> @@ -379,7 +379,7 @@ static int __init imxdma_probe(struct platform_device *pdev)
> return 0;
>
> err_init:
> - while (i-- >= 0) {
> + while (--i >= 0) {
> struct imxdma_channel *imxdmac = &imxdma->channel[i];
> imx_dma_free(imxdmac->imxdma_channel);
> }
> --
> 1.7.2
>
>
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-02 7:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-02 1:56 [PATCH Resend] dma: imx-dma: fix imxdma_probe error path Axel Lin
2010-11-02 7:40 ` Pengutronix
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome