From: Mike Waychison <mikew@google.com>
To: simon.kagstrom@netinsight.net, davem@davemloft.net,
nhorman@tuxdriver.com, Matt Mackall <mpm@selenic.com>
Cc: adurbin@google.com, linux-kernel@vger.kernel.org,
chavey@google.com, "Greg KH" <greg@kroah.com>,
"Américo Wang" <xiyou.wangcong@gmail.com>,
akpm@linux-foundation.org, linux-api@vger.kernel.org
Subject: [PATCH v2 22/23] netoops: Add one-shot mode
Date: Mon, 08 Nov 2010 12:33:47 -0800 [thread overview]
Message-ID: <20101108203346.22479.10201.stgit@crlf.mtv.corp.google.com> (raw)
In-Reply-To: <20101108203120.22479.19708.stgit@crlf.mtv.corp.google.com>
Sometimes it is possible to have a kernel crashing that continuously
Oopses. In this case, we do not want the network dumper get called over
and over again, as we may only be interested in the first Oops that a
kernel emits (especially in cases where we panic_on_oops).
In order to support this dumping policy, this commit introduces a file
call /proc/sys/kernel/net_dump_one_shot that contains a boolean as to
whether or not the netoops driver will operate in one-shot mode.
Note that 'soft' dumps do not disable the netoops driver when one-shot
mode is enabled.
Signed-off-by: Mike Waychison <mikew@google.com>
---
TODO: ABI needs a better home.
---
drivers/net/netoops.c | 37 +++++++++++++++++++++++++++++++++++++
1 files changed, 37 insertions(+), 0 deletions(-)
diff --git a/drivers/net/netoops.c b/drivers/net/netoops.c
index 5cbb732..1ffd0f0 100644
--- a/drivers/net/netoops.c
+++ b/drivers/net/netoops.c
@@ -97,6 +97,8 @@ struct netoops_msg {
} __attribute__ ((packed));
static struct netoops_msg msg;
+static int network_dumper_one_shot = 1;
+static int network_dumper_disabled;
static char netoops_fw_version[80];
static char netoops_board_name[80];
@@ -221,6 +223,10 @@ static void netoops(struct kmsg_dumper *dumper, enum kmsg_dump_reason reason,
netoops_send_segment(packet_count_2, s1, l1);
}
+ /* Should we disable ourselves now? */
+ if (!soft_dump && network_dumper_one_shot)
+ network_dumper_disabled = 1;
+
spin_unlock_irqrestore(&targets.lock, flags);
}
@@ -282,6 +288,28 @@ static struct kmsg_dumper netoops_dumper = {
.dump = netoops,
};
+static struct ctl_table kern_table[] = {
+ {
+ .procname = "net_dump_one_shot",
+ .data = &network_dumper_one_shot,
+ .maxlen = sizeof(int),
+ .mode = 0644,
+ .proc_handler = &proc_dointvec,
+ },
+ {},
+};
+
+static struct ctl_table root_table[] = {
+ {
+ .procname = "kernel",
+ .mode = 0555,
+ .child = kern_table,
+ },
+ {}
+};
+
+static struct ctl_table_header *proc_table_header;
+
static int __init netoops_init(void)
{
int retval = -EINVAL;
@@ -309,7 +337,15 @@ static int __init netoops_init(void)
if (retval)
goto out_sysfs_group;
+ proc_table_header = register_sysctl_table(root_table);
+ if (!proc_table_header) {
+ retval = -EINVAL;
+ goto out_kmsg_dump;
+ }
+
return 0;
+out_kmsg_dump:
+ kmsg_dump_unregister(&netoops_dumper);
out_sysfs_group:
sysfs_remove_group(netoops_kobj, &attr_group);
out_kobj:
@@ -322,6 +358,7 @@ out:
static void __exit netoops_exit(void)
{
+ unregister_sysctl_table(proc_table_header);
kmsg_dump_unregister(&netoops_dumper);
sysfs_remove_group(netoops_kobj, &attr_group);
kobject_put(netoops_kobj);
next prev parent reply other threads:[~2010-11-08 20:34 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-08 20:31 [PATCH v2 00/23] netoops support Mike Waychison
2010-11-08 20:31 ` [PATCH v2 01/23] netconsole: Remove unneeded reference counting Mike Waychison
2010-11-08 20:31 ` [PATCH v2 02/23] netconsole: Introduce locking over the netpoll fields Mike Waychison
2010-11-08 20:31 ` [PATCH v2 03/23] netconsole: Introduce 'enabled' state-machine Mike Waychison
2010-11-08 20:32 ` [PATCH v2 04/23] netconsole: Call netpoll_cleanup() in process context Mike Waychison
2010-11-09 12:07 ` Neil Horman
2010-11-09 17:18 ` Mike Waychison
2010-11-09 19:33 ` Neil Horman
2010-11-08 20:32 ` [PATCH v2 05/23] netconsole: Wrap the list and locking in a structure Mike Waychison
2010-11-08 20:32 ` [PATCH v2 06/23] netconsole: Push configfs_subsystem into netpoll_targets Mike Waychison
2010-11-08 20:32 ` [PATCH v2 07/23] netconsole: Move netdev_notifier " Mike Waychison
2010-11-08 20:32 ` [PATCH v2 08/23] netconsole: Split out netpoll_targets init/exit Mike Waychison
2010-11-08 20:32 ` [PATCH v2 09/23] netconsole: Add pointer to netpoll_targets Mike Waychison
2010-11-08 20:32 ` [PATCH v2 10/23] netconsole: Rename netconsole_target -> netpoll_target Mike Waychison
2010-11-08 20:32 ` [PATCH v2 11/23] netconsole: Abstract away the subsystem name Mike Waychison
2010-11-08 20:32 ` [PATCH v2 12/23] netpoll: Introduce netpoll_target configs Mike Waychison
2010-11-09 3:30 ` Américo Wang
2010-11-09 4:27 ` Américo Wang
2010-11-09 8:34 ` Mike Waychison
2010-11-09 9:06 ` Américo Wang
2010-11-09 9:38 ` [RFC PATCH] configfs: make it not be a module any more Américo Wang
2010-11-09 14:20 ` [PATCH v2 12/23] netpoll: Introduce netpoll_target configs Greg KH
2010-11-09 17:24 ` Mike Waychison
2010-11-09 17:27 ` Greg KH
2010-11-08 20:32 ` [PATCH v2 13/23] netconsole: Move setting of default ports Mike Waychison
2010-11-08 20:32 ` [PATCH v2 14/23] netpoll: Move target code into netpoll_targets.c Mike Waychison
2010-11-08 20:33 ` [PATCH v2 15/23] Oops: Pass regs to oops_exit() Mike Waychison
2010-11-08 20:33 ` [PATCH v2 16/23] kmsg_dumper: Pass pt_regs along to dumpers Mike Waychison
2010-11-08 20:33 ` [PATCH v2 17/23] kmsg_dumper: Introduce a new 'SOFT' dump reason Mike Waychison
2010-11-09 5:49 ` KOSAKI Motohiro
2010-11-09 5:54 ` KOSAKI Motohiro
2010-11-08 20:33 ` [PATCH v2 18/23] sys-rq: Add option to soft dump Mike Waychison
2010-11-08 21:09 ` Randy Dunlap
2010-11-08 22:27 ` Mike Waychison
2010-11-08 22:31 ` Randy Dunlap
2010-11-08 20:33 ` [PATCH v2 19/23] netoops: add core functionality Mike Waychison
2010-11-08 20:33 ` [PATCH v2 20/23] netoops: Add x86 specific bits to packet headers Mike Waychison
2010-11-09 14:22 ` Neil Horman
2010-11-09 17:56 ` Mike Waychison
2010-11-08 20:33 ` [PATCH v2 21/23] netoops: Add user programmable fields to the netoops packet Mike Waychison
2010-11-08 20:33 ` Mike Waychison [this message]
2010-11-08 20:33 ` [PATCH v2 23/23] netoops: Add an interface to trigger various types of crashes Mike Waychison
2010-11-08 20:55 ` [PATCH v2 00/23] netoops support Matt Mackall
2010-11-08 21:20 ` David Miller
2010-11-08 21:43 ` Mike Waychison
2010-11-09 1:28 ` Andi Kleen
2010-11-09 4:25 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108203346.22479.10201.stgit@crlf.mtv.corp.google.com \
--to=mikew@google.com \
--cc=adurbin@google.com \
--cc=akpm@linux-foundation.org \
--cc=chavey@google.com \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=nhorman@tuxdriver.com \
--cc=simon.kagstrom@netinsight.net \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome