mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Martin Wilck <martin.wilck@ts.fujitsu.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Wichert, Gerhard" <gerhard.wichert@ts.fujitsu.com>,
	Greg KH <greg@kroah.com>
Subject: Re: [PATCH] fix size checks for mmap() on /proc/bus/pci files (resent)
Date: Tue, 9 Nov 2010 08:42:06 -0800	[thread overview]
Message-ID: <20101109084206.1b6ac66a@jbarnes-desktop> (raw)
In-Reply-To: <4CD917AB.6070705@ts.fujitsu.com>

On Tue, 09 Nov 2010 10:43:07 +0100
Martin Wilck <martin.wilck@ts.fujitsu.com> wrote:

> Hi Jesse & linux-pci,
> 
> may I kindly ask if anyone has had a look at this patch yet?
> 
> https://patchwork.kernel.org/patch/270271/
> http://kerneltrap.org/mailarchive/linux-kernel/2010/10/21/4635039

Yes I looked at it, and then promptly lost it in my inbox.

Thanks for fixing this; /proc/bus/pci semantics are definitely
different than /sys so we definitely want this.

I don't really like the new int argument to pci_mmap_fits (it's not
obvious from reading callers what that arg would do), maybe you could
make it into an enum that better describes the API or semantic being
used for the check?

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

  reply	other threads:[~2010-11-09 16:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-21  8:38 martin.wilck
2010-11-09  9:43 ` Martin Wilck
2010-11-09 16:42   ` Jesse Barnes [this message]
2010-11-10 10:03     ` [PATCH] fix size checks for mmap() on /proc/bus/pci files (updated) Martin Wilck
2010-11-10 18:44       ` Jesse Barnes
2010-11-10 19:29         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101109084206.1b6ac66a@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=gerhard.wichert@ts.fujitsu.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=martin.wilck@ts.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome