* [PATCH] ide: fix use after free in ide-acpi
@ 2010-11-22 19:34 Mariusz Kozlowski
2010-11-22 19:37 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Mariusz Kozlowski @ 2010-11-22 19:34 UTC (permalink / raw)
To: David S. Miller; +Cc: linux-ide, linux-kernel, Mariusz Kozlowski
out_obj points to kfreed memory and we dereference that pointer in
DEBPRINT/printk.
Signed-off-by: Mariusz Kozlowski <mk@lab.zgora.pl>
---
drivers/ide/ide-acpi.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ide/ide-acpi.c b/drivers/ide/ide-acpi.c
index c26c119..2af8cb4 100644
--- a/drivers/ide/ide-acpi.c
+++ b/drivers/ide/ide-acpi.c
@@ -416,21 +416,21 @@ void ide_acpi_get_timing(ide_hwif_t *hwif)
out_obj = output.pointer;
if (out_obj->type != ACPI_TYPE_BUFFER) {
- kfree(output.pointer);
DEBPRINT("Run _GTM: error: "
"expected object type of ACPI_TYPE_BUFFER, "
"got 0x%x\n", out_obj->type);
+ kfree(output.pointer);
return;
}
if (!out_obj->buffer.length || !out_obj->buffer.pointer ||
out_obj->buffer.length != sizeof(struct GTM_buffer)) {
- kfree(output.pointer);
printk(KERN_ERR
"%s: unexpected _GTM length (0x%x)[should be 0x%zx] or "
"addr (0x%p)\n",
__func__, out_obj->buffer.length,
sizeof(struct GTM_buffer), out_obj->buffer.pointer);
+ kfree(output.pointer);
return;
}
--
1.7.0.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ide: fix use after free in ide-acpi
2010-11-22 19:34 [PATCH] ide: fix use after free in ide-acpi Mariusz Kozlowski
@ 2010-11-22 19:37 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-11-22 19:37 UTC (permalink / raw)
To: mk; +Cc: linux-ide, linux-kernel
From: Mariusz Kozlowski <mk@lab.zgora.pl>
Date: Mon, 22 Nov 2010 20:34:38 +0100
> out_obj points to kfreed memory and we dereference that pointer in
> DEBPRINT/printk.
>
> Signed-off-by: Mariusz Kozlowski <mk@lab.zgora.pl>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-22 19:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-22 19:34 [PATCH] ide: fix use after free in ide-acpi Mariusz Kozlowski
2010-11-22 19:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®