mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] romfs: have romfs_fs.h pull in necessary headers
Date: Mon, 22 Nov 2010 16:43:56 -0800	[thread overview]
Message-ID: <20101122164356.ab44c4ae.akpm@linux-foundation.org> (raw)
In-Reply-To: <AANLkTikJQ4usvm9tx1Xm+LcfFgduMVRqPyQPpkYUyjff@mail.gmail.com>

On Mon, 22 Nov 2010 19:40:16 -0500
Mike Frysinger <vapier@gentoo.org> wrote:

> On Mon, Nov 22, 2010 at 16:58, Andrew Morton wrote:
> > On Sun, 21 Nov 2010 19:24:21 -0500 Mike Frysinger wrote:
> >> This header uses things like __be32, so pull in linux/types.h.
> >>
> >> Further, it uses BLOCK_SIZE, so pull in linux/fs.h.
> >>
> >> --- a/include/linux/romfs_fs.h
> >> +++ b/include/linux/romfs_fs.h
> >> @@ -1,6 +1,9 @@
> >> __#ifndef __LINUX_ROMFS_FS_H
> >> __#define __LINUX_ROMFS_FS_H
> >>
> >> +#include <linux/types.h>
> >> +#include <linux/fs.h>
> >> +
> >> __/* The basic structures of the romfs filesystem */
> >>
> >> __#define ROMBSIZE BLOCK_SIZE
> >
> > Better changelogs please.
> >
> > Does this fix any build error? __If so, is that build error present in
> > 2.6.36 or earlier?
> 
> headers should include the headers that define types/things that the
> header itself needs

I take that to mean "no" and "no", hence the fix is not needed in
2.6.37 and is not needed in -stable.

Thanks for being so helpful.

  reply	other threads:[~2010-11-23  0:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-22  0:24 Mike Frysinger
2010-11-22 21:58 ` Andrew Morton
2010-11-23  0:40   ` Mike Frysinger
2010-11-23  0:43     ` Andrew Morton [this message]
2010-11-23  1:27       ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101122164356.ab44c4ae.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome