From: Mike Frysinger <vapier@gentoo.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] romfs: have romfs_fs.h pull in necessary headers
Date: Mon, 22 Nov 2010 19:40:16 -0500 [thread overview]
Message-ID: <AANLkTikJQ4usvm9tx1Xm+LcfFgduMVRqPyQPpkYUyjff@mail.gmail.com> (raw)
In-Reply-To: <20101122135855.6825700d.akpm@linux-foundation.org>
On Mon, Nov 22, 2010 at 16:58, Andrew Morton wrote:
> On Sun, 21 Nov 2010 19:24:21 -0500 Mike Frysinger wrote:
>> This header uses things like __be32, so pull in linux/types.h.
>>
>> Further, it uses BLOCK_SIZE, so pull in linux/fs.h.
>>
>> --- a/include/linux/romfs_fs.h
>> +++ b/include/linux/romfs_fs.h
>> @@ -1,6 +1,9 @@
>> #ifndef __LINUX_ROMFS_FS_H
>> #define __LINUX_ROMFS_FS_H
>>
>> +#include <linux/types.h>
>> +#include <linux/fs.h>
>> +
>> /* The basic structures of the romfs filesystem */
>>
>> #define ROMBSIZE BLOCK_SIZE
>
> Better changelogs please.
>
> Does this fix any build error? If so, is that build error present in
> 2.6.36 or earlier?
headers should include the headers that define types/things that the
header itself needs
-mike
next prev parent reply other threads:[~2010-11-23 0:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 0:24 Mike Frysinger
2010-11-22 21:58 ` Andrew Morton
2010-11-23 0:40 ` Mike Frysinger [this message]
2010-11-23 0:43 ` Andrew Morton
2010-11-23 1:27 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikJQ4usvm9tx1Xm+LcfFgduMVRqPyQPpkYUyjff@mail.gmail.com \
--to=vapier@gentoo.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®