Re: [PATCH] kernel: make /proc/kallsyms mode 400 to reduce ease of attacking

[Ingo Molnar <mingo@elte.hu>]

* Kees Cook <kees.cook@canonical.com> wrote:

> On Thu, Nov 18, 2010 at 08:48:04AM +0100, Ingo Molnar wrote:
> > Agreed. A few other kernel address things that should be hidden are:
> > [snip]
> 
> For reference, here's what GRKERNSEC_HIDESYM looks like in grsecurity.
> It's quite a sledgehammer, but it does help to point out at least the
> minimum number of things that need fixing.

Yeah, it's a somewhat disgusting patch - but it also looks useful.

It would be more palatable for upstream if it was:

 - split up

 - if all those GRKERNSEC_HIDESYM #ifdefs were removed, either by making the 
   grsecurity defaults the default behavior, or by intelligently hiding it behinds 
   wrappers.

I'd suggest a single CONFIG_LEGACY_SYMBOLS=y config option for this, but only used 
to show those symbols that are absolutely needed for compatibility - like 
/proc/kallsyms. (Newer distros could disable this option and the kernel could 
eventually default to it being disabled as well.)

Also, while changing hexa output to symbolic output is fine, changing the oops 
output is borderline - that is an absolutely useful piece of information that helps 
us in decoding crashes. So i'd suggest to split that into a super-paranoid option or 
so.

Anyway, after a split-up we'll see how good the individual bits are - it's a bit of 
a mixed bag right now.

Thanks,

	Ingo