* [PATCH 1/2] rdc321x-gpio: fix null pointer dereference while accessing platform_data
@ 2010-11-26 9:39 Florian Fainelli
2010-11-26 12:15 ` Samuel Ortiz
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2010-11-26 9:39 UTC (permalink / raw)
To: sameo; +Cc: linux-kernel, Wim Van Sebroeck
rdc321x-gpio currently fetches its driver specific data by using the platform_
device->platform_data pointer, this is wrong because the mfd device which
registers our platform_device has been added using mfd_add_device() which sets
the platform_device->driver_data pointer instead.
Signed-off-by: Florian Fainelli <florian@openwrt.org>
CC: stable@kernel.org
---
This patch should be applied for the next 2.6.36 stable release.
diff --git a/drivers/gpio/rdc321x-gpio.c b/drivers/gpio/rdc321x-gpio.c
index 2762698..897e057 100644
--- a/drivers/gpio/rdc321x-gpio.c
+++ b/drivers/gpio/rdc321x-gpio.c
@@ -135,7 +135,7 @@ static int __devinit rdc321x_gpio_probe(struct platform_device *pdev)
struct rdc321x_gpio *rdc321x_gpio_dev;
struct rdc321x_gpio_pdata *pdata;
- pdata = pdev->dev.platform_data;
+ pdata = platform_get_drvdata(pdev);
if (!pdata) {
dev_err(&pdev->dev, "no platform data supplied\n");
return -ENODEV;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] rdc321x-gpio: fix null pointer dereference while accessing platform_data
2010-11-26 9:39 [PATCH 1/2] rdc321x-gpio: fix null pointer dereference while accessing platform_data Florian Fainelli
@ 2010-11-26 12:15 ` Samuel Ortiz
2010-11-29 7:59 ` Wim Van Sebroeck
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Ortiz @ 2010-11-26 12:15 UTC (permalink / raw)
To: Florian Fainelli; +Cc: linux-kernel, Wim Van Sebroeck
Hi Florian,
On Fri, Nov 26, 2010 at 10:39:54AM +0100, Florian Fainelli wrote:
> rdc321x-gpio currently fetches its driver specific data by using the platform_
> device->platform_data pointer, this is wrong because the mfd device which
> registers our platform_device has been added using mfd_add_device() which sets
> the platform_device->driver_data pointer instead.
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> CC: stable@kernel.org
I'll take those 2 patches.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] rdc321x-gpio: fix null pointer dereference while accessing platform_data
2010-11-26 12:15 ` Samuel Ortiz
@ 2010-11-29 7:59 ` Wim Van Sebroeck
0 siblings, 0 replies; 3+ messages in thread
From: Wim Van Sebroeck @ 2010-11-29 7:59 UTC (permalink / raw)
To: Samuel Ortiz, Florian Fainelli; +Cc: linux-kernel
Hi Samuel, Florian,
You also have my ACK for the watchdog driver.
Kind regards,
Wim.
> Hi Florian,
>
> On Fri, Nov 26, 2010 at 10:39:54AM +0100, Florian Fainelli wrote:
> > rdc321x-gpio currently fetches its driver specific data by using the platform_
> > device->platform_data pointer, this is wrong because the mfd device which
> > registers our platform_device has been added using mfd_add_device() which sets
> > the platform_device->driver_data pointer instead.
> >
> > Signed-off-by: Florian Fainelli <florian@openwrt.org>
> > CC: stable@kernel.org
> I'll take those 2 patches.
>
> Cheers,
> Samuel.
>
> --
> Intel Open Source Technology Centre
> http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-29 7:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-26 9:39 [PATCH 1/2] rdc321x-gpio: fix null pointer dereference while accessing platform_data Florian Fainelli
2010-11-26 12:15 ` Samuel Ortiz
2010-11-29 7:59 ` Wim Van Sebroeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome